Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dojo events and migrate commands #52

Merged
merged 9 commits into from
Apr 8, 2024
Merged

Add dojo events and migrate commands #52

merged 9 commits into from
Apr 8, 2024

Conversation

gianalarcon
Copy link
Collaborator

@gianalarcon gianalarcon commented Apr 5, 2024

  • Use #[dojo::event] along #[derive(starknet::Event)].
  • Update sozo migrate commands on script.
  • Add move script.
  • Clean Files.

After this PR is merged, I can updated the hello-dojo tutorial

Scarb.toml Outdated Show resolved Hide resolved
scripts/move.sh Outdated Show resolved Hide resolved
src/models/moves.cairo Outdated Show resolved Hide resolved
Copy link
Contributor

@notV4l notV4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i left a few comment

@notV4l
Copy link
Contributor

notV4l commented Apr 5, 2024

default_auth.sh need some path update too

@gianalarcon gianalarcon marked this pull request as draft April 5, 2024 11:24
@gianalarcon gianalarcon changed the title Feat: Add dojo events and migrate commands WIP: Add dojo events and migrate commands Apr 5, 2024
Scarb.toml Outdated Show resolved Hide resolved
src/models/moves.cairo Outdated Show resolved Hide resolved
scripts/move.sh Outdated Show resolved Hide resolved
scripts/default_auth.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gianalarcon for the changes! Could you also remove the old abis folder? Thanks man!

scripts/default_auth.sh Outdated Show resolved Hide resolved
@gianalarcon gianalarcon changed the title WIP: Add dojo events and migrate commands Add dojo events and migrate commands Apr 6, 2024
@gianalarcon gianalarcon marked this pull request as ready for review April 6, 2024 02:53
Copy link
Contributor

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @gianalarcon for the effort here. 🙏

@gianalarcon gianalarcon merged commit ec48ac1 into main Apr 8, 2024
2 checks passed
@gianalarcon gianalarcon deleted the starter-update branch April 8, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants