feat: improve direction type + add check on 'can_move' #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartianGreed
force-pushed
the
feat/update-models
branch
from
8a67ef7 to
fc72b97
Compare
glihm
reviewed
Jan 5, 2025
src/models.cairo
Outdated
| @@ -1,12 +1,13 @@ | |||
| use starknet::ContractAddress; | |||
| use starknet::{ContractAddress}; | |||
| use core::option::Option; | |||
There was a problem hiding this comment.
Option is not into the prelude? If not, let's try to update the edition to see if we can avoid to import that.
src/systems/actions.cairo
Outdated
| @@ -48,7 +48,7 @@ pub mod actions { | |||
|
|
|||
| // 2. Set the player's remaining moves to 100. | |||
| let moves = Moves { | |||
| player, remaining: 100, last_direction: Direction::None(()), can_move: true | |||
| player, remaining: 100, last_direction: core::Option::None, can_move: true | |||
There was a problem hiding this comment.
Suggested change
| player, remaining: 100, last_direction: core::Option::None, can_move: true | |
| player, remaining: 100, last_direction: Option::None, can_move: true |
would be great to avoid having to import core this way is possible.
|
Wondering if generally speaking we should revamp this example as we discussed to map to a front-end game with all the different part of the stack used: models, events, historical events, etc.. |
MartianGreed
force-pushed
the
feat/update-models
branch
from
fc72b97 to
dcc5c59
Compare
glihm
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.