Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release: v1.0.10 #2886

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Prepare release: v1.0.10 #2886

merged 1 commit into from
Jan 9, 2025

Conversation

tarrencev
Copy link
Contributor

@tarrencev tarrencev commented Jan 9, 2025

Automated changes by create-pull-request GitHub action

Summary by CodeRabbit

  • Version Update

    • Incremented project version from 1.0.9 to 1.0.10 across multiple configuration files
    • Updated version in Cargo.toml and Scarb.toml files for various packages and components
  • Dependency Changes

    • Added libp2p-websocket-websys dependency for WebAssembly target in Torii libp2p configuration

Copy link

coderabbitai bot commented Jan 9, 2025

Walkthrough

Ohayo, sensei! This pull request primarily involves version bumping across multiple Rust and Scarb project configuration files from version 1.0.9 to 1.0.10. Additionally, there's a specific dependency addition for the libp2p WebSocket WebSys target in the Torii library, and a minor formatting adjustment in the typed-data Cargo.toml.

Changes

File Change Summary
Cargo.toml Version updated from 1.0.9 to 1.0.10
crates/dojo/core/Scarb.toml Version updated from 1.0.9 to 1.0.10
crates/torii/libp2p/Cargo.toml Added libp2p-websocket-websys dependency for WASM target
crates/torii/typed-data/Cargo.toml Added newline, no functional change
crates/torii/types-test/Scarb.toml Version updated from 1.0.9 to 1.0.10
examples/spawn-and-move/Scarb.toml Version updated from 1.0.9 to 1.0.10

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1829ce5 and 4caddf0.

⛔ Files ignored due to path filters (4)
  • Cargo.lock is excluded by !**/*.lock
  • crates/dojo/core/Scarb.lock is excluded by !**/*.lock
  • crates/torii/types-test/Scarb.lock is excluded by !**/*.lock
  • examples/spawn-and-move/Scarb.lock is excluded by !**/*.lock
📒 Files selected for processing (6)
  • Cargo.toml (1 hunks)
  • crates/dojo/core/Scarb.toml (1 hunks)
  • crates/torii/libp2p/Cargo.toml (1 hunks)
  • crates/torii/typed-data/Cargo.toml (1 hunks)
  • crates/torii/types-test/Scarb.toml (1 hunks)
  • examples/spawn-and-move/Scarb.toml (1 hunks)
✅ Files skipped from review due to trivial changes (5)
  • crates/torii/types-test/Scarb.toml
  • crates/dojo/core/Scarb.toml
  • Cargo.toml
  • crates/torii/typed-data/Cargo.toml
  • examples/spawn-and-move/Scarb.toml
🔇 Additional comments (1)
crates/torii/libp2p/Cargo.toml (1)

53-53: Ohayo! The dependency addition looks good, sensei!

The new WebSocket dependency for WASM target is consistent with other libp2p dependencies, using the same Git repository and revision.

Let's verify if we need any additional features for the WebSocket dependency:

✅ Verification successful

Ohayo! The WebSocket dependency configuration is perfect, sensei!

The setup is complete with:

  • Core WebSocket protocol enabled via websocket feature in main libp2p
  • WASM-specific implementation added without need for additional features
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if any other crates in the workspace use libp2p-websocket-websys with specific features
rg -g 'Cargo.toml' 'libp2p-websocket-websys.*features'

Length of output: 54


Script:

#!/bin/bash
# Check for any WebSocket-related dependencies and their configurations
rg -g 'Cargo.toml' 'libp2p.*websocket'

# Look at the general pattern of libp2p dependency configurations
rg -g 'Cargo.toml' '\[dependencies\.libp2p-' -A 2

Length of output: 459


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@glihm glihm enabled auto-merge (squash) January 9, 2025 20:03
@glihm glihm merged commit 4371331 into main Jan 9, 2025
13 checks passed
@glihm glihm deleted the prepare-release branch January 9, 2025 20:12
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.81%. Comparing base (1829ce5) to head (4caddf0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2886      +/-   ##
==========================================
- Coverage   55.82%   55.81%   -0.01%     
==========================================
  Files         449      449              
  Lines       57693    57693              
==========================================
- Hits        32207    32202       -5     
- Misses      25486    25491       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants