Add start param to MTTR endpoints #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinMGranger
force-pushed
the
mttr-offset
branch
from
5720027 to
fe10842
Compare
etsauer
reviewed
Feb 8, 2024
| // TODO: `@` in right spot? | ||
| static final String LEAD_TIME_FOR_CHANGE = "avg_over_time(sdp:lead_time:global [%s] @ %s)"; | ||
| static final String BY_APP = "avg_over_time(sdp:lead_time:by_app{app=~'.*%s.*'}[%s] @ %s)"; | ||
| static final String BY_APP_OFFSET = "avg_over_time(sdp:lead_time:by_app{app=~'.*%1$s.*'}[%2$s] offset %2$s)"; |
| static final String BY_APP_OFFSET = "avg_over_time(sdp:lead_time:by_app{app=~'.*%1$s.*'}[%2$s] offset %2$s)"; | ||
| // It should be this, once https://github.com/dora-metrics/pelorus/issues/1088 | ||
| // gets resolved | ||
| static final String BY_APP_DATA = "sdp:lead_time:by_commit{app=~'.*%s.*'}[%s]"; |
| } | ||
|
|
||
| // #region Change Failure Rate | ||
| // TODO: making sure I understand where the @ would go on the below queries | ||
| private final String CHANGE_FAILURE_RATE = "(count by (app) (count_over_time(failure_creation_timestamp{app!=\"unknown\"}[%1$s]) or sdp:lead_time:by_app * 0) / count_over_time(sdp:lead_time:by_app [%1$s]))"; |
- log queries - take mandatory "start" parameter - use a more structured argument approach
KevinMGranger
force-pushed
the
mttr-offset
branch
from
a78f6ff to
c109024
Compare
KevinMGranger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some items in #19