Merge branch 'develop' into feature/add-missing-request-parameters

dorana · Jan 16, 2020 · e1552c7 · e1552c7
2 parents b797b89 + b391d98
commit e1552c7
Show file tree

Hide file tree

Showing 6 changed files with 37 additions and 25 deletions.
diff --git a/...Tests/Test/PaymentTests/PaymentOrder/Anonymous/AnonymousPaymentOrderAuthorizationTests.cs b/...Tests/Test/PaymentTests/PaymentOrder/Anonymous/AnonymousPaymentOrderAuthorizationTests.cs
@@ -46,13 +46,14 @@ public async Task Anonymous_PaymentOrder_Card_Authorization(Product[] products,
                         Is.EqualTo(State.Completed));
 
             // Order Items
+
             Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList.Count, Is.EqualTo(products.Count()));
             for (var i = 0; i < products.Count(); i++)
             {
-                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList[i].Name, Is.EqualTo(products[i].Name));
-                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList[i].UnitPrice.Value, Is.EqualTo(products[i].UnitPrice));
-                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList[i].Quantity, Is.EqualTo(products[i].Quantity));
-                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList[i].Amount.Value, Is.EqualTo(products[i].UnitPrice * products[i].Quantity));
+                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList.ElementAt(i).Name, Is.EqualTo(products[i].Name));
+                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList.ElementAt(i).UnitPrice.Value, Is.EqualTo(products[i].UnitPrice));
+                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList.ElementAt(i).Quantity, Is.EqualTo(products[i].Quantity));
+                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList.ElementAt(i).Amount.Value, Is.EqualTo(products[i].UnitPrice * products[i].Quantity));
             }
         }
 
@@ -92,10 +93,10 @@ public async Task Anonymous_PaymentOrder_Invoice_Authorization(Product[] product
             Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList.Count, Is.EqualTo(products.Count()));
             for (var i = 0; i < products.Count(); i++)
             {
-                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList[i].Name, Is.EqualTo(products[i].Name));
-                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList[i].UnitPrice.Value, Is.EqualTo(products[i].UnitPrice));
-                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList[i].Quantity, Is.EqualTo(products[i].Quantity));
-                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList[i].Amount.Value, Is.EqualTo(products[i].UnitPrice * products[i].Quantity));
+                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList.ElementAt(i).Name, Is.EqualTo(products[i].Name));
+                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList.ElementAt(i).UnitPrice.Value, Is.EqualTo(products[i].UnitPrice));
+                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList.ElementAt(i).Quantity, Is.EqualTo(products[i].Quantity));
+                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList.ElementAt(i).Amount.Value, Is.EqualTo(products[i].UnitPrice * products[i].Quantity));
             }
         }
 

diff --git a/...re.SystemTests/Test/PaymentTests/PaymentOrder/Anonymous/AnonymousPaymentOrderSaleTests.cs b/...re.SystemTests/Test/PaymentTests/PaymentOrder/Anonymous/AnonymousPaymentOrderSaleTests.cs
@@ -49,10 +49,10 @@ public async Task Anonymous_PaymentOrder_Swish_Sale(Product[] products, PayexInf
             Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList.Count, Is.EqualTo(products.Count()));
             for (var i = 0; i < products.Count(); i++)
             {
-                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList[i].Name, Is.EqualTo(products[i].Name));
-                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList[i].UnitPrice.Value, Is.EqualTo(products[i].UnitPrice));
-                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList[i].Quantity, Is.EqualTo(products[i].Quantity));
-                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList[i].Amount.Value, Is.EqualTo(products[i].UnitPrice * products[i].Quantity));
+                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList.ElementAt(i).Name, Is.EqualTo(products[i].Name));
+                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList.ElementAt(i).UnitPrice.Value, Is.EqualTo(products[i].UnitPrice));
+                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList.ElementAt(i).Quantity, Is.EqualTo(products[i].Quantity));
+                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList.ElementAt(i).Amount.Value, Is.EqualTo(products[i].UnitPrice * products[i].Quantity));
             }
         }
 

diff --git a/...emTests/Test/PaymentTests/PaymentOrder/Standard/StandardPaymentOrderAuthorizationTests.cs b/...emTests/Test/PaymentTests/PaymentOrder/Standard/StandardPaymentOrderAuthorizationTests.cs
@@ -49,10 +49,10 @@ public async Task Standard_PaymentOrder_Card_Authorization(Product[] products, P
             Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList.Count, Is.EqualTo(products.Count()));
             for (var i = 0; i < products.Count(); i++)
             {
-                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList[i].Name, Is.EqualTo(products[i].Name));
-                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList[i].UnitPrice.Value, Is.EqualTo(products[i].UnitPrice));
-                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList[i].Quantity, Is.EqualTo(products[i].Quantity));
-                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList[i].Amount.Value, Is.EqualTo(products[i].UnitPrice * products[i].Quantity));
+                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList.ElementAt(i).Name, Is.EqualTo(products[i].Name));
+                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList.ElementAt(i).UnitPrice.Value, Is.EqualTo(products[i].UnitPrice));
+                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList.ElementAt(i).Quantity, Is.EqualTo(products[i].Quantity));
+                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList.ElementAt(i).Amount.Value, Is.EqualTo(products[i].UnitPrice * products[i].Quantity));
             }
         }
 
@@ -92,10 +92,10 @@ public async Task Standard_PaymentOrder_Invoice_Authorization(Product[] products
             Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList.Count, Is.EqualTo(products.Count()));
             for (var i = 0; i < products.Count(); i++)
             {
-                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList[i].Name, Is.EqualTo(products[i].Name));
-                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList[i].UnitPrice.Value, Is.EqualTo(products[i].UnitPrice));
-                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList[i].Quantity, Is.EqualTo(products[i].Quantity));
-                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList[i].Amount.Value, Is.EqualTo(products[i].UnitPrice * products[i].Quantity));
+                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList.ElementAt(i).Name, Is.EqualTo(products[i].Name));
+                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList.ElementAt(i).UnitPrice.Value, Is.EqualTo(products[i].UnitPrice));
+                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList.ElementAt(i).Quantity, Is.EqualTo(products[i].Quantity));
+                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList.ElementAt(i).Amount.Value, Is.EqualTo(products[i].UnitPrice * products[i].Quantity));
             }
         }
 

diff --git a/...Core.SystemTests/Test/PaymentTests/PaymentOrder/Standard/StandardPaymentOrderSaleTests.cs b/...Core.SystemTests/Test/PaymentTests/PaymentOrder/Standard/StandardPaymentOrderSaleTests.cs
@@ -49,10 +49,10 @@ public async Task Standard_PaymentOrder_Swish_Sale(Product[] products, PayexInfo
             Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList.Count, Is.EqualTo(products.Count()));
             for (var i = 0; i < products.Count(); i++)
             {
-                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList[i].Name, Is.EqualTo(products[i].Name));
-                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList[i].UnitPrice.Value, Is.EqualTo(products[i].UnitPrice));
-                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList[i].Quantity, Is.EqualTo(products[i].Quantity));
-                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList[i].Amount.Value, Is.EqualTo(products[i].UnitPrice * products[i].Quantity));
+                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList.ElementAt(i).Name, Is.EqualTo(products[i].Name));
+                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList.ElementAt(i).UnitPrice.Value, Is.EqualTo(products[i].UnitPrice));
+                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList.ElementAt(i).Quantity, Is.EqualTo(products[i].Quantity));
+                Assert.That(order.PaymentOrderResponse.OrderItems.OrderItemList.ElementAt(i).Amount.Value, Is.EqualTo(products[i].UnitPrice * products[i].Quantity));
             }
         }
 

diff --git a/src/SwedbankPay.Sdk/PaymentOrders/OrderItems.cs b/src/SwedbankPay.Sdk/PaymentOrders/OrderItems.cs
@@ -4,12 +4,16 @@ namespace SwedbankPay.Sdk.PaymentOrders
 {
     public class OrderItems : IdLink
     {
+        public OrderItems(IEnumerable<OrderItem> orderItemList)
+        {
+            OrderItemList = orderItemList;
+        }
         /// <summary>
         ///     The orderItems property of the paymentOrder is an array containing the items being purchased with the order. Used
         ///     to print on invoices if
         ///     the payer chooses to pay with invoice, among other things. Order items can be specified on both payment order
         ///     creation as well as on Capture.
         /// </summary>
-        public List<OrderItem> OrderItemList { get; set; }
+        public IEnumerable<OrderItem> OrderItemList { get; set; }
     }
 }
diff --git a/src/SwedbankPay.Sdk/PaymentOrders/PaymentOrderResource.cs b/src/SwedbankPay.Sdk/PaymentOrders/PaymentOrderResource.cs
@@ -1,6 +1,9 @@
 using System;
+using System.Net.Http;
 using System.Threading.Tasks;
 
+using SwedbankPay.Sdk.Exceptions;
+
 namespace SwedbankPay.Sdk.PaymentOrders
 {
     internal class PaymentOrderResource : ResourceBase, IPaymentOrderResource
@@ -29,6 +32,10 @@ public async Task<PaymentOrder> Create(PaymentOrderRequest paymentOrderRequest,
         /// <param name="id"></param>
         /// <param name="paymentOrderExpand"></param>
         /// <returns></returns>
+        /// <exception cref="ArgumentNullException"></exception>
+        /// <exception cref="InvalidOperationException"></exception>
+        /// <exception cref="HttpRequestException"></exception>
+        /// <exception cref="HttpResponseException"></exception>
         public Task<PaymentOrder> Get(Uri id, PaymentOrderExpand paymentOrderExpand = PaymentOrderExpand.None)
         {
             if (id == null)