Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: πŸ› react-player couldn't find package "@dotlottie/common" #251

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

theashraf
Copy link
Member

βœ… Closes: #250

Description

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Docs: Documentation updates (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested my changes on the player-component and React player.

@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2023

πŸ¦‹ Changeset detected

Latest commit: 8f56141

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@dotlottie/react-player Patch
dotlottie-playground Patch
react-player-next Patch
react-player-test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@theashraf theashraf marked this pull request as ready for review October 18, 2023 05:30
@theashraf theashraf requested a review from afsalz October 18, 2023 05:31
@github-actions
Copy link
Contributor

size-limit report πŸ“¦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/common/dist/index.js 7.37 KB (0%) 148 ms (0%) 162 ms (+170.3% πŸ”Ί) 309 ms
packages/player-component/dist/dotlottie-player.mjs 30.92 KB (0%) 619 ms (0%) 168 ms (+99.65% πŸ”Ί) 787 ms

@afsalz afsalz merged commit 34afa16 into master Oct 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Couldn't find package "@dotlottie/common@^0.7.1"
2 participants