Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace structuredClone with Object.assign #258

Merged
merged 2 commits into from
Nov 6, 2023
Merged

fix: replace structuredClone with Object.assign #258

merged 2 commits into from
Nov 6, 2023

Conversation

yash1200
Copy link
Contributor

@yash1200 yash1200 commented Nov 4, 2023

Description

Replaces structuredClone with Object.assign in dotlottie-player.ts
Fixes - #256

Type of change

Affects common/src/dotlottie-player.ts

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Docs: Documentation updates (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested my changes on the player-component and React player.

Copy link

changeset-bot bot commented Nov 4, 2023

⚠️ No Changeset found

Latest commit: 5efc8c8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@theashraf theashraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR.

I have just one small comment: please kindly add a changeset to each of the packages to increment the patch version.
For contribution guidelines, refer to: https://github.com/dotlottie/player-component#contributing

.eslintrc.js Outdated Show resolved Hide resolved
@theashraf theashraf merged commit c4fad1d into dotlottie:master Nov 6, 2023
2 checks passed
@yash1200 yash1200 deleted the fix/structuredClone branch November 6, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants