Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 setAutoplay fired on initial load next14 #269

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

afsalz
Copy link
Contributor

@afsalz afsalz commented Dec 6, 2023

Description

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Docs: Documentation updates (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested my changes on the player-component and React player.

@afsalz afsalz linked an issue Dec 6, 2023 that may be closed by this pull request
Copy link

changeset-bot bot commented Dec 6, 2023

🦋 Changeset detected

Latest commit: 14e0f83

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@dotlottie/react-player Patch
dotlottie-playground Patch
react-player-next Patch
react-player-test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@afsalz afsalz requested a review from theashraf December 6, 2023 04:01
Copy link
Contributor

github-actions bot commented Dec 6, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/common/dist/index.js 7.42 KB (0%) 149 ms (0%) 77 ms (+58.19% 🔺) 225 ms
packages/player-component/dist/dotlottie-player.mjs 31.59 KB (0%) 632 ms (0%) 62 ms (+7.57% 🔺) 694 ms

@afsalz afsalz merged commit fbf5b55 into master Dec 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[react-player] setAutoplay() Can't use whilst loading. warning in console
2 participants