Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 box-sizing css rule scope #318

Merged
merged 2 commits into from
Mar 5, 2024
Merged

fix: 🐛 box-sizing css rule scope #318

merged 2 commits into from
Mar 5, 2024

Conversation

theashraf
Copy link
Member

Description

fix #317

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Docs: Documentation updates (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested my changes on the player-component and React player.

Copy link

changeset-bot bot commented Mar 5, 2024

🦋 Changeset detected

Latest commit: 44e6ac1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@dotlottie/player-component Patch
@dotlottie/react-player Patch
next Patch
nuxt-app Patch
react Patch
vue Patch
web Patch
dotlottie-playground Patch
react-player-next Patch
react-player-test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 5, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/common/dist/index.js 7.45 KB (0%) 149 ms (0%) 159 ms (+264.66% 🔺) 308 ms
packages/player-component/dist/dotlottie-player.mjs 31.64 KB (-0.02% 🔽) 633 ms (-0.02% 🔽) 162 ms (+198.23% 🔺) 794 ms

Copy link
Contributor

@afsalz afsalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theashraf theashraf merged commit 0587998 into master Mar 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Box-sizing border-box
2 participants