Call Tensor::alias() when returning an input Tensor
#1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The continuous integration failed, but I don't see how I did anything wrong. |
ds5678
changed the title
Tensor::alias() when concatenating a list of count 1Tensor::alias() when returning an input Tensor
I haven't done this because the wording was ambiguous on whether or not I should, and I didn't want to cause merge conflicts with any other pull requests. |
|
Is there anything I need to do in order for this to be merged? It's blocking my third pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that disposing the result has the same impact as it would with a different size.