Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add activity-alias support #9654

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Conversation

dellis1972
Copy link
Contributor

@dellis1972 dellis1972 commented Jan 7, 2025

Context
https://dev.azure.com/devdiv/DevDiv/_workitems/edit/2305723
https://github.com/mattleibow/MauiAppWithMultipleIcons

Apparently launching an activity-alias was not supported at all. That probably means very few people use it, however we really should be able to launch them.

The changes to android-platform-support include the ability for GetAndroidActivityName to find activity-alias elements which have the correct metadata. This allows us to launch them via the typical Run command to launch them.

Added a unit test.

@dellis1972
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dellis1972
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines failed to run 1 pipeline(s).

@dellis1972
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines failed to run 1 pipeline(s).

@dellis1972
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dellis1972
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines failed to run 1 pipeline(s).

@dellis1972
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dellis1972 dellis1972 force-pushed the dev/dellis1972/activity-alias branch from 65da40a to a173909 Compare January 9, 2025 08:35
@dellis1972
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dellis1972 dellis1972 force-pushed the dev/dellis1972/activity-alias branch from a173909 to b5b4571 Compare January 9, 2025 15:53
@dellis1972
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dellis1972 dellis1972 force-pushed the dev/dellis1972/activity-alias branch from 5c75c95 to fcc310b Compare January 14, 2025 15:31
@dellis1972
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dellis1972 dellis1972 force-pushed the dev/dellis1972/activity-alias branch from 5dabbe9 to 5a5855e Compare January 16, 2025 09:02
@dellis1972
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dellis1972 dellis1972 changed the title Test the activity-alias changes Add activity-alias support Jan 22, 2025
@dellis1972 dellis1972 marked this pull request as ready for review January 22, 2025 12:09
@dellis1972 dellis1972 force-pushed the dev/dellis1972/activity-alias branch from 5a5855e to 7d79d64 Compare January 22, 2025 12:10
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New test is green:

image

@jonathanpeppers jonathanpeppers merged commit fed4208 into main Jan 22, 2025
56 of 58 checks passed
@jonathanpeppers jonathanpeppers deleted the dev/dellis1972/activity-alias branch January 22, 2025 16:11
grendello added a commit that referenced this pull request Jan 22, 2025
* main:
  [XABT] Create separate assembly preparation tasks. (#9637)
  Add `activity-alias` support (#9654)
  [CI] Grab 'dotnet-install.sh' script directly from GitHub. (#9699)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants