Add RemoveDependency method to DependencyFileManager #4405
+322
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/Microsoft.DotNet.Darc/DarcLib/Helpers/DependencyFileManager.cs:243
- [nitpick] The error message 'Couldn't find dependency {dependency.Name} in Version.props' could be more descriptive. Consider changing it to 'Dependency {dependency.Name} not found in Version.props. Ensure the dependency name is correct and exists in the file.'
throw new DependencyException("Couldn't find dependency {dependency.Name} in Version.props");
src/Microsoft.DotNet.Darc/DarcLib/Helpers/DependencyFileManager.cs:258
- [nitpick] The error message 'Dependency {dependency.Name} not found in Version.Details.xml' could be more descriptive. Consider changing it to 'Dependency {dependency.Name} not found in Version.Details.xml. Ensure the dependency name is correct and exists in the file.'
throw new DependencyException("Dependency {dependency.Name} not found in Version.Details.xml");
premun
reviewed
Jan 31, 2025
| @@ -211,6 +211,57 @@ public async Task AddDependencyAsync( | |||
| await AddDependencyToVersionDetailsAsync(repoUri, branch, dependency); | |||
| } | |||
|
|
|||
| public async Task RemoveDependencyAsync(DependencyDetail dependency, string repoUri, string branch) | |||
There was a problem hiding this comment.
How about the dotnet tool config? Would that also be easy to do too?
premun
previously approved these changes
Feb 4, 2025
Comment on lines
240
to
256
| if (dotnetTools != null) | ||
| { | ||
| var tools = dotnetTools["tools"] as JObject; | ||
| if (tools != null) | ||
| { | ||
| // we have to do this because JObject is case sensitive | ||
| var toolProperty = tools.Properties().FirstOrDefault(p => p.Name.Equals(dependency.Name, StringComparison.OrdinalIgnoreCase)); | ||
| if (toolProperty != null) | ||
| { | ||
| tools.Remove(toolProperty.Name); | ||
| } | ||
|
|
||
| return dotnetTools; | ||
| } | ||
| } | ||
|
|
||
| return null; |
There was a problem hiding this comment.
Can we swap the if and reduce nesting?
There was a problem hiding this comment.
done, VS also did some fancy pattern matching stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4390
Adds a
RemoveDependencyAsyncmethod with the same API asAddDependencyAsync