-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure credentials update #15111
Azure credentials update #15111
Conversation
3805f20
to
a62085f
Compare
a62085f
to
0c1c6c4
Compare
@pavel-purma Still need this? |
eng/publishing/v3/publish.yml
Outdated
inputs: | ||
azureSubscription: maestro-build-promotion | ||
addSpnToEnvironment: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does the pipeline credential get access to publish blobs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will use AzurePipelinesCredential when SYSTEM_ACCESSTOKEN environment variable provided. If not, ManagedIdentity/AzureCliCredential would be configured to ChainedTokenCredential
75530cf
to
5078af8
Compare
@mmitche, this PR switches from DefaultAzureCredential to AzurePipelineCredential (DefaultIdentityTokenCredential standard pipeline authentication) which can issue tokens even after 10 minutes expiration issue of federated token. Authentication mechanism is also faster than in cases when DefaultAzureCredential falls to AzureCliCredential. In blob publishing this is already in use. Here, this code enables it also for symbols publishing. |
var ret = new ChainedTokenCredential(tokenCredentials.ToArray()); | ||
return ret; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var ret = new ChainedTokenCredential(tokenCredentials.ToArray()); | |
return ret; | |
return new ChainedTokenCredential(tokenCredentials.ToArray()); |
Update Azure Identity Credentials