Infer the projects runtime identifier as the vertical's RID when doing a vertical build and filter down RID lists to the target RID in such a scenario #15371
+86
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g a vertical build and filter down RID lists to the target RID in such a scenario.
…enable the experience (which the orchestrator will set for the correct repos).
ViktorHofer
force-pushed
the
target-vertical-rid
branch
from
88236ac to
e669601
Compare
|
Should we un-draft the PR now and get it merged? |
ViktorHofer
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In vertical builds, repos that build targeting the live runtime only have one runtime available, the runtime for the target RID. Add a new UB control property (which will need updates in the orchestrator to pass correctly) to select a default RID (the target RID) before the SDK infers one.
Contributes to dotnet/source-build#4784
To double check: