Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify how we resolve argument and env variables #7360

Merged
merged 4 commits into from
Feb 1, 2025

Conversation

davidfowl
Copy link
Member

Description

  • De-dupe the logic that we use to resolve environment variables and arguments in run and publish mode. This was done for both tests and product code. We now have a single way to resolve values.
  • Updated manifests

Fixes #7256
Fixes #6644

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

- De-dupe the logic that we use to resolve environment variables and arguments in run and publish mode. This was done for both tests and product code. We now have a single way to resolve values.
- Updated manifests
@davidfowl davidfowl requested a review from mitchdenny as a code owner February 1, 2025 09:05
@DamianEdwards DamianEdwards merged commit 12e92d7 into main Feb 1, 2025
32 checks passed
@DamianEdwards DamianEdwards deleted the davidfowl/unify-resolve-behavior branch February 1, 2025 18:45
return env;
}

/// <summary>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to fix these copilot generated comments 😄.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants