Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullable reference types in F# #44047

Merged
merged 15 commits into from
Jan 22, 2025
Merged

Nullable reference types in F# #44047

merged 15 commits into from
Jan 22, 2025

Conversation

@dotnetrepoman dotnetrepoman bot added this to the December 2024 milestone Dec 20, 2024
@psfinaki
Copy link
Member Author

@T-Gro PTAL - I didn't want to copypaste your whole blog post to one place so tried to distribute the information among the various related docs... If you think I over- or under-copied something, let me know, will update this accordingly - the null-related information shouldn't be overwhelming but should be exhaustive.

@T-Gro
Copy link
Member

T-Gro commented Dec 30, 2024

A checklist of things I expect to see in the docs (will tick the ones I identified while reviewing):

  • Syntax change for type definition
  • Ways of handling null (pattern match, active patterns, one or two selected library functions)
  • Recommended usage (interop, vanilla F# prefers option for indicating absence of value) == guidelines
  • Generic type constraints (null and not null)
  • Nullable Project property
  • CLI fsc.exe and fsi settings
  • Conditional DEFINE added by project property

@BillWagner BillWagner modified the milestones: December 2024, January 2025 Jan 6, 2025
@psfinaki psfinaki marked this pull request as ready for review January 7, 2025 16:01
@psfinaki
Copy link
Member Author

psfinaki commented Jan 7, 2025

@T-Gro thanks for the checklist, all valid points, I think I have addressed the missing parts.

@psfinaki
Copy link
Member Author

@BillWagner @KathleenDollard PTAL at the English side of things :)

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I had one formatting suggestion to highlight that nullable reference types are designed for interop

docs/fsharp/language-reference/values/null-values.md Outdated Show resolved Hide resolved
@BillWagner BillWagner enabled auto-merge (squash) January 22, 2025 18:20
@BillWagner BillWagner merged commit 5452826 into main Jan 22, 2025
8 checks passed
@BillWagner BillWagner deleted the fs-nulls branch January 22, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc updates for F# 9 features
3 participants