Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributed tracing in networking #44063

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

antonfirsov
Copy link
Member

@antonfirsov antonfirsov commented Dec 23, 2024

This is a major rework of #42830, extending the content, making the information more specific and IMO easier to follow. The biggest change is the in the collection paragraphs:

  • I dropped the definitions of terms instrumentation, collection, export, OpenTelemetry etc., given that we were already using them in the intro, so it felt rather pointless to define them at that point; IMO the reader is looking for practical guidelines and examples anyways.
  • Instead, I added a summary of the available methods, so readers can navigate the document following their preferences and goals.
  • Metrics.md: Added back the dotnet-monitor example. Reintroduced a short paragraph on prometheus/grafana, since the referenced docs need some augmentation.

Internal previews

📄 File 🔗 Preview link
docs/core/diagnostics/distributed-tracing-builtin-activities.md Built-in activities in .NET
docs/fundamentals/networking/telemetry/metrics.md Networking metrics
docs/fundamentals/networking/telemetry/overview.md Networking telemetry in .NET
docs/fundamentals/networking/telemetry/tracing.md docs/fundamentals/networking/telemetry/tracing
docs/fundamentals/toc.yml docs/fundamentals/toc

@antonfirsov antonfirsov modified the milestones: December 2024, April 2025 Dec 25, 2024
Comment on lines +130 to +134
### View metrics in Grafana with OpenTelemetry and Prometheus

1. Follow the [standard instructions](https://prometheus.io/docs/visualization/grafana/#installing) to install Grafana and connect it to a Prometheus data source.
Please follow our tutorial on [Using OpenTelemetry with Prometheus, Grafana, and Jaeger](../../../core/diagnostics/observability-prgrja-example.md), but note that the tutorial does not particularly discuss `HttpClient` metrics.

1. Create a Grafana dashboard by selecting the **+** icon on the top toolbar then selecting **Dashboard**. In the dashboard editor that appears, enter **Open HTTP/1.1 Connections** in the **Title** box and the following query in the PromQL expression field:
There are two additions you need to make:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we could omit this paragraph, but we need to extend observability-prgrja-example.md for that.

@antonfirsov antonfirsov marked this pull request as ready for review January 8, 2025 18:44
@antonfirsov antonfirsov requested a review from samsp-msft January 8, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant