-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define common Ubuntu coredeps Dockerfile #1121
Conversation
src/ubuntu/manifest.json
Outdated
@@ -15,6 +15,9 @@ | |||
"ubuntu-20.04-coredeps-local": { | |||
"isLocal": true | |||
} | |||
}, | |||
"buildArgs": { | |||
"POWERSHELL_TAG": "lts-7.2-ubuntu-20.04" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to define a versions manifest to start putting these types of valuesin? The benefit is to ease maintenance by getting them next to each other. Possibly the value could be decomposed so that the pwsh version is a shared value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I'm kind of inclined to just change it to a non-version floating tag: lts-ubuntu-20.04
. That's essentially the same as installing it via package manager as far what version you end up getting:
apt-get install -y powershell && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the tag usage to get the latest PowerShell version available. This aligns with the version that gets installed by other Dockerfiles that are installing from PMC. This will give you PowerShell 7.4 in both cases.
There is some cleanup of other PowerShell usage amongst the Dockerfiles but that's outside the scope of coredeps so I'll address those separately.
The Ubuntu coredeps Dockerfiles reference out-of-date resources:
src/ubuntu/20.04/coredeps/Dockerfile
:src/ubuntu/22.04/coredeps/Dockerfile
:I've fixed this by defining a common Dockerfile that is shared for both Ubuntu versions. Each now references a supported PowerShell base image tag. And the AZ CLI install script is used to ensure the latest version gets installed.