Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define common Ubuntu coredeps Dockerfile #1121

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

mthalman
Copy link
Member

@mthalman mthalman commented Jul 1, 2024

The Ubuntu coredeps Dockerfiles reference out-of-date resources:

I've fixed this by defining a common Dockerfile that is shared for both Ubuntu versions. Each now references a supported PowerShell base image tag. And the AZ CLI install script is used to ensure the latest version gets installed.

@mthalman mthalman requested a review from a team as a code owner July 1, 2024 14:53
@@ -15,6 +15,9 @@
"ubuntu-20.04-coredeps-local": {
"isLocal": true
}
},
"buildArgs": {
"POWERSHELL_TAG": "lts-7.2-ubuntu-20.04"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to define a versions manifest to start putting these types of valuesin? The benefit is to ease maintenance by getting them next to each other. Possibly the value could be decomposed so that the pwsh version is a shared value.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I'm kind of inclined to just change it to a non-version floating tag: lts-ubuntu-20.04. That's essentially the same as installing it via package manager as far what version you end up getting:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the tag usage to get the latest PowerShell version available. This aligns with the version that gets installed by other Dockerfiles that are installing from PMC. This will give you PowerShell 7.4 in both cases.

There is some cleanup of other PowerShell usage amongst the Dockerfiles but that's outside the scope of coredeps so I'll address those separately.

src/ubuntu/common/coredeps/Dockerfile Outdated Show resolved Hide resolved
@mthalman mthalman requested a review from MichaelSimons July 8, 2024 17:21
@mthalman mthalman enabled auto-merge (squash) July 8, 2024 17:49
@mthalman mthalman merged commit dcf0bb9 into dotnet:main Jul 8, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants