Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NLS test scenario #6120

Merged
merged 6 commits into from
Jan 6, 2025
Merged

Add NLS test scenario #6120

merged 6 commits into from
Jan 6, 2025

Conversation

lbussell
Copy link
Contributor

NLS is Windows-only, so I defined a completely separate scenario for it that runs only on Windows.

The test uses the recommended method for determining whether or not we're using ICU, and then validates some of the differences between NLS and ICU behavior based on what it finds.

For now, we will expect that NLS is used on all Nano Server images, and ICU is used on all Windows Server Core images. ICU has been the default on Server Core since .NET 7 and Server Core LTSC 2019. See https://learn.microsoft.com/en-us/dotnet/core/compatibility/globalization/7.0/icu-globalization-api for more context there.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • tests/Microsoft.DotNet.Docker.Tests/Microsoft.DotNet.Docker.Tests.csproj: Language not supported
  • tests/Microsoft.DotNet.Docker.Tests/TestAppArtifacts/NLSTest.Dockerfile: Language not supported
  • tests/Microsoft.DotNet.Docker.Tests/AspnetImageTests.cs: Evaluated as low risk
Comments suppressed due to low confidence (2)

tests/Microsoft.DotNet.Docker.Tests/TestScenarios/NLSScenario.cs:54

  • Incorrect array initializer syntax. Use curly braces '{}' instead of square brackets '[]'.
string[] buildArgs = [

tests/Microsoft.DotNet.Docker.Tests/RuntimeImageTests.cs:52

  • Ensure that the new VerifyNLSScenario method is covered by tests.
public async Task VerifyNLSScenario(ProductImageData imageData) =>
@lbussell lbussell requested a review from mthalman December 20, 2024 20:53
@lbussell lbussell requested a review from mthalman January 6, 2025 20:57
@lbussell lbussell enabled auto-merge (squash) January 6, 2025 22:12
@lbussell lbussell merged commit 715cde0 into dotnet:nightly Jan 6, 2025
99 checks passed
lbussell added a commit to lbussell/dotnet-docker that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants