Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize translation tests by declaring type, with a dedicated model #34872

Closed
roji opened this issue Oct 10, 2024 · 1 comment · Fixed by #35319
Closed

Reorganize translation tests by declaring type, with a dedicated model #34872

roji opened this issue Oct 10, 2024 · 1 comment · Fixed by #35319
Assignees
Milestone

Comments

@roji
Copy link
Member

roji commented Oct 10, 2024

When we want to add tests for method/member translations, we sometimes do that in Northwind, and sometimes in GearsOfWar. Northwind is generally bad because it has very few types, and has restricted data for those types (we can't add data to Northwind - it's frozen). GearsOfWar has the disadvantage of having lots of different versions (for different inheritance types, etc.), so if you add a small translation test, you suddenly have to add lots of versions of that tests - with duplicated SQL baselines - though that doesn't add any meaningful coverage. GearsOfWar also generally evolved to be a bit of a fallback/mess, where we frequently shove stuff into it without too much systematic design etc.; it's also not implemented by Cosmos because there's too much incompatible stuff in there.

We should consider having a test suite geared specifically for method/member translations. The model would be simple, no relationalships, and aim to cover all the basic database types and relevant data for all the types as well. We'd take care that tests there don't break as data as added, so that we can easily add data to support new tests without having to unbreak old ones. This would start us moving away from Northwind/GearsOfWar, in a more structured/clean direction etc.

If the number of tests is too big, we can consider having a common model with multiple test suites (like the Northwind tests).

Work:

PostgreSQL work:

@roji roji added this to the MQ milestone Oct 10, 2024
@roji roji assigned roji and unassigned maumar Dec 4, 2024
@roji
Copy link
Member Author

roji commented Dec 4, 2024

Am poaching this.

@roji roji modified the milestones: MQ, 10.0.0 Dec 4, 2024
roji added a commit to roji/efcore that referenced this issue Dec 10, 2024
roji added a commit to roji/efcore that referenced this issue Dec 11, 2024
roji added a commit to roji/efcore that referenced this issue Dec 11, 2024
roji added a commit to roji/efcore that referenced this issue Dec 11, 2024
roji added a commit to roji/efcore that referenced this issue Dec 11, 2024
roji added a commit to roji/efcore that referenced this issue Dec 11, 2024
roji added a commit to roji/efcore that referenced this issue Dec 11, 2024
roji added a commit to roji/efcore that referenced this issue Dec 11, 2024
roji added a commit to roji/efcore that referenced this issue Dec 17, 2024
roji added a commit to roji/efcore that referenced this issue Dec 17, 2024
Random, DateTime.Parse/new, bitwise operators

Continues dotnet#34872
roji added a commit to roji/efcore that referenced this issue Dec 17, 2024
Random, DateTime.Parse/new, bitwise operators

Continues dotnet#34872
roji added a commit to roji/efcore that referenced this issue Dec 18, 2024
Random, DateTime.Parse/new, bitwise operators

Continues dotnet#34872
roji added a commit to roji/efcore that referenced this issue Dec 18, 2024
Random, DateTime.Parse/new, bitwise operators

Continues dotnet#34872
roji added a commit that referenced this issue Dec 18, 2024
Random, DateTime.Parse/new, bitwise operators

Continues #34872
roji added a commit to roji/efcore that referenced this issue Dec 22, 2024
@roji roji changed the title Have a tests suite (or model) specifically for method/member translations Reorganize translation tests by declaring type, with a dedicated model Dec 22, 2024
roji added a commit to roji/efcore that referenced this issue Jan 10, 2025
roji added a commit that referenced this issue Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants