-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor method/member translation tests into their own suite #35319
Conversation
0015683
to
4d48e59
Compare
4d48e59
to
3730161
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 49 out of 64 changed files in this pull request and generated 1 suggestion.
Files not reviewed (15)
- test/EFCore.Specification.Tests/Query/NorthwindNavigationsQueryTestBase.cs: Evaluated as low risk
- test/EFCore.Specification.Tests/Query/NorthwindWhereQueryTestBase.cs: Evaluated as low risk
- test/EFCore.Cosmos.FunctionalTests/Query/Translations/MiscellaneousTranslationsCosmosTest.cs: Evaluated as low risk
- test/EFCore.Specification.Tests/Query/NorthwindSelectQueryTestBase.cs: Evaluated as low risk
- test/EFCore.InMemory.FunctionalTests/Query/NorthwindWhereQueryInMemoryTest.cs: Evaluated as low risk
- test/EFCore.InMemory.FunctionalTests/Query/Translations/BasicTypesQueryInMemoryFixture.cs: Evaluated as low risk
- test/EFCore.Specification.Tests/Query/Translations/BasicTypesQueryFixtureBase.cs: Evaluated as low risk
- test/EFCore.Specification.Tests/Query/OwnedQueryTestBase.cs: Evaluated as low risk
- test/EFCore.Relational.Specification.Tests/Query/NorthwindWhereQueryRelationalTestBase.cs: Evaluated as low risk
- test/EFCore.Relational.Specification.Tests/Query/NorthwindFunctionsQueryRelationalTestBase.cs: Evaluated as low risk
- test/EFCore.Specification.Tests/Query/NorthwindAggregateOperatorsQueryTestBase.cs: Evaluated as low risk
- test/EFCore.InMemory.FunctionalTests/Query/NorthwindFunctionsQueryInMemoryTest.cs: Evaluated as low risk
- test/EFCore.InMemory.FunctionalTests/Query/Translations/TemporalTranslationsInMemoryTest.cs: Evaluated as low risk
- test/EFCore.InMemory.FunctionalTests/Query/Translations/MathTranslationsInMemoryTest.cs: Evaluated as low risk
- test/EFCore.InMemory.FunctionalTests/Query/Translations/EnumTranslationsInMemoryTest.cs: Evaluated as low risk
Comments skipped due to low confidence (1)
test/EFCore.InMemory.FunctionalTests/Query/Translations/StringTranslationsInMemoryTest.cs:6
- Syntax error in class declaration. It should be 'public class StringTranslationsInMemoryTest : StringTranslationsTestBase' instead of 'public class StringTranslationsInMemoryTest(BasicTypesQueryInMemoryFixture fixture) : StringTranslationsTestBase(fixture);'.
public class StringTranslationsInMemoryTest(BasicTypesQueryInMemoryFixture fixture) : StringTranslationsTestBase<BasicTypesQueryInMemoryFixture>(fixture);
.../EFCore.InMemory.FunctionalTests/Query/Translations/MiscellaneousTranslationsInMemoryTest.cs
Show resolved
Hide resolved
test/EFCore.Cosmos.FunctionalTests/Query/Translations/BasicTypesQueryCosmosFixture.cs
Show resolved
Hide resolved
test/EFCore.Specification.Tests/TestModels/BasicTypesModel/BasicFlagsEnum.cs
Show resolved
Hide resolved
|
||
public bool Bool { get; set; } | ||
public Guid Guid { get; set; } | ||
public required byte[] ByteArray { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing unsigned types, char, Half 😁, Uri, IPAddress, PhysicalAddress
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add these as needed no? Especially given we don't actually support any translations e.g. on IPAddress/PhysicalAddress? For PG which supports these, I was planning to add properties to the model (e.g. in a separate entity) and have extra translations test suites to exercise that (something like this already in EFCore.PG).
In other words, for now the types I've added were mostly types for which there are already existing tests that would exercise them - but I think it should be fine to add more types later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndriySvyryd I'm going to go ahead and merge this without the additional types, for now. I agree with you that at least some of these make sense, but let's add them later as needed (I've already spent enough time here...).
This introduces a new BasicTypes model, and reorganizes many of our method/member translation tests into new test suites under Query/Translations.
Closes #34872