Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish the AotCompatibility.TestApp project as part of PR validation #5622

Merged
merged 19 commits into from
Nov 13, 2024
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
002cdb7
Remove AI in Microsoft.Extensions.AI.AotCompatibility.TestApp
eerhardt Nov 11, 2024
86deeab
Clean up the AotCompatibility.TestApp
eerhardt Nov 11, 2024
c847f9a
Make dotnet test publish the TestApp and fail if there are any warnin…
eerhardt Nov 11, 2024
10fcb7b
Hook the Test target as well so the test runs in CI
eerhardt Nov 11, 2024
33e95b8
Move clean logic to target.
eerhardt Nov 11, 2024
9fbc27c
- Add tracing issues.
eerhardt Nov 11, 2024
fbf2866
Add tracking issue links for OpenAI and Azure.AI.Inference trim/AOT c…
eerhardt Nov 11, 2024
5b2b7a2
Merge remote-tracking branch 'upstream/main' into AotCI
eerhardt Nov 12, 2024
ff0bf8c
Add an exclusion for Microsoft.Extensions.AI.Abstractions
eerhardt Nov 12, 2024
12b8949
Exclude Microsoft.Extensions.AI as well, since it hits the warnings i…
eerhardt Nov 12, 2024
7d554db
Cache current process object to avoid performance hit (#5597)
haipz Nov 12, 2024
9c675f1
Remove cleaning from publish
eerhardt Nov 12, 2024
f228df9
Merge remote-tracking branch 'upstream/main' into AotCI
eerhardt Nov 12, 2024
5b33969
Remove MS.Ext.AI now that the issue is resolved.
eerhardt Nov 12, 2024
47beb96
Temporarily disable the test to figure out what is causing the code c…
eerhardt Nov 12, 2024
0a4bbee
Revert "Temporarily disable the test to figure out what is causing th…
eerhardt Nov 12, 2024
e690bbf
try running during BuildAndTest.yml
eerhardt Nov 12, 2024
30dae3d
Remove testing cruft from TestApp project
eerhardt Nov 12, 2024
4cd0228
Change TrimmerRootAssembly to use FileName to be correct.
eerhardt Nov 13, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,14 @@

<PropertyGroup>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<EnableConfigurationBindingGenerator>true</EnableConfigurationBindingGenerator>
<InjectStringSyntaxAttributeOnLegacy>true</InjectStringSyntaxAttributeOnLegacy>
<InjectExperimentalAttributeOnLegacy>true</InjectExperimentalAttributeOnLegacy>
<InjectSharedDiagnosticIds>true</InjectSharedDiagnosticIds>
<InjectSharedNumericExtensions>true</InjectSharedNumericExtensions>
<InjectSharedDataValidation>true</InjectSharedDataValidation>

<!-- using the ConfigurationBinder source generator is blocked by https://github.com/dotnet/runtime/issues/94547 -->
<!-- https://github.com/dotnet/extensions/issues/5623 -->
<IsAotCompatible>false</IsAotCompatible>
<NoWarn>$(NoWarn);IL2026</NoWarn>
</PropertyGroup>
Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
<Project>
<Import Project="Sdk.props" Sdk="Microsoft.NET.Sdk" />

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>$(LatestTargetFramework)</TargetFramework>
<!-- clear TargetFrameworks because it is set in ..\Directory.Build.props -->
<TargetFrameworks></TargetFrameworks>
<PublishAot>true</PublishAot>
<TrimmerSingleWarn>false</TrimmerSingleWarn>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>

<ItemGroup>
<!-- Remove the ReferenceTrimmer analyzer. We explicitly want to reference every assembly so the AOT compiler sees it. -->
<PackageReference Remove="ReferenceTrimmer" />

<LibraryProjects Include="$(RepoRoot)\src\Libraries\**\*.csproj" />
<!-- Azure.AI.Inference produces many warnings -->
eerhardt marked this conversation as resolved.
Show resolved Hide resolved
<LibraryProjects Remove="$(RepoRoot)\src\Libraries\Microsoft.Extensions.AI.AzureAIInference\Microsoft.Extensions.AI.AzureAIInference.csproj" />
<!-- OpenAI produces a few warnings-->
<LibraryProjects Remove="$(RepoRoot)\src\Libraries\Microsoft.Extensions.AI.OpenAI\Microsoft.Extensions.AI.OpenAI.csproj" />
<!-- https://github.com/dotnet/extensions/issues/5624 -->
<LibraryProjects Remove="$(RepoRoot)\src\Libraries\Microsoft.Extensions.Caching.Hybrid\Microsoft.Extensions.Caching.Hybrid.csproj" />
<!-- https://github.com/dotnet/extensions/issues/5623 -->
<LibraryProjects Remove="$(RepoRoot)\src\Libraries\Microsoft.Extensions.Compliance.Redaction\Microsoft.Extensions.Compliance.Redaction.csproj" />
<!-- https://github.com/dotnet/extensions/issues/5625 -->
<LibraryProjects Remove="$(RepoRoot)\src\Libraries\Microsoft.Extensions.Http.Resilience\Microsoft.Extensions.Http.Resilience.csproj" />

<TrimmerRootAssembly Include="@(LibraryProjects->'%(Identity)')" />
<ProjectReference Include="@(LibraryProjects)" />
</ItemGroup>

<Import Project="Sdk.targets" Sdk="Microsoft.NET.Sdk" />

<Target Name="PublishProject">
<!-- Always clean before publishing so we get warnings/errors every time. -->
<Exec Command="$(DOTNET_HOST_PATH) clean -c Release"
WorkingDirectory="$(MSBuildProjectDirectory)" />

<Exec Command="$(DOTNET_HOST_PATH) publish -c Release"
WorkingDirectory="$(MSBuildProjectDirectory)" />
</Target>

<!-- Override Test and VSTest so testing publishes this app and fails if there are any warnings/errors -->
<!-- Needs to be defined after importing the Sdk.targets -->
<Target Name="Test" DependsOnTargets="PublishProject" />
eerhardt marked this conversation as resolved.
Show resolved Hide resolved
<Target Name="VSTest" DependsOnTargets="Test" />

</Project>
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

System.Console.WriteLine("Success!");
Loading