Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the Header and Footer-Name textbox is cut off in collection view #26947

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

NanthiniMahalingam
Copy link
Contributor

@NanthiniMahalingam NanthiniMahalingam commented Jan 3, 2025

Issue Details:

  • When dynamically changing the CollectionView's width, the end portion of the CollectionView header's and footer's children gets cut off.
  • This issue has been raised in CollectionView1 alone.

Root Cause

  • The HeaderView frame update scenario is not considered when the CollectionView size changes.
  • ⁠The FooterView frame updates only for a CollectionView with an ItemSource; it does not update when the CollectionView does not contain any items.

Description of Change

  • Considered the HeaderView frame update when the CollectionView size changes.
  • Updated the FooterView frame where the CollectionView does not contain items, applicable to both horizontal and vertical layouts.

Issues Fixed

Fixes #26186

Validated the behaviour in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

Output

iOS platform

Before After
Before_iOS.mov
After_iOS.mov

macOS platform

Before After
Before_macOS.mov
After_macOS.mov

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jan 3, 2025
@sheiksyedm sheiksyedm added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Jan 3, 2025
@NanthiniMahalingam NanthiniMahalingam marked this pull request as ready for review January 7, 2025 12:36
@NanthiniMahalingam NanthiniMahalingam requested a review from a team as a code owner January 7, 2025 12:36
@rmarinho
Copy link
Member

rmarinho commented Jan 7, 2025

/azp run

This comment was marked as outdated.

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jfversluis jfversluis added the area-controls-collectionview CollectionView, CarouselView, IndicatorView label Jan 9, 2025
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing UITest HeaderAndFooterShouldBeVisible is failing.

VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: HeaderAndFooterShouldBeVisible.png (2.16% difference)

There are small differences, could you take a look?
image

@NanthiniMahalingam
Copy link
Contributor Author

The existing UITest HeaderAndFooterShouldBeVisible is failing.

VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: HeaderAndFooterShouldBeVisible.png (2.16% difference)

There are small differences, could you take a look? image

Hi @jsuarezruiz

  • The HeaderAndFooterShouldBeVisible failed case is unrelated to my fix and has been excluded for the Mac platform in the latest merge ([testing] Skip tests that fail on Catalyst #27010).
  • Therefore, I have rebased the branch to resolve the snapshot difference issue.

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MAUI]I8_Header and Footer-Name textbox is cut off
5 participants