Add way to LoadProject with caches ect #11234
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Suggestion of new API for setting ProjectOptions on created
ProjectContext
Setting EvaluationContext when working with
Projectis not optimal becuase of its interaction with theProjectCollection.If I create a
ProjectwithProjectOptionsI can get exception if im creating the same project multiple times, as the ProjectCollection will fail adding it to its internal lists.To handle this best ive added a
LoadProjectWithOptionson the ProjectCollection, as this will create it with the options if its not already created, making it possible to ie. setup EvaluationContext to Shared.Changes Made
Added new method
ProjectCollection.LoadProjectWithOptionsTesting
Notes