Make the ActivityCTS test more reliable

dotnet · Dec 16, 2024 · a10c42e · a10c42e
1 parent 40fdad5
commit a10c42e
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/test/ReverseProxy.Tests/Utilities/ActivityCancellationTokenSourceTests.cs b/test/ReverseProxy.Tests/Utilities/ActivityCancellationTokenSourceTests.cs
@@ -11,12 +11,12 @@ namespace Yarp.ReverseProxy.Utilities.Tests;
 public class ActivityCancellationTokenSourceTests
 {
     [Fact]
-    public void ActivityCancellationTokenSource_PoolsSources()
+    public async Task ActivityCancellationTokenSource_PoolsSources()
     {
-        // This test can run in parallel with others making use of ActivityCancellationTokenSource
-        // A different thread could have already added/removed a source from the queue
+        // This test can run in parallel with others making use of ActivityCancellationTokenSource.
+        // A different thread could have already added/removed a source from the queue (hence the retries).
 
-        for (var i = 0; i < 1000; i++)
+        for (var i = 0; i < 10_000; i++)
         {
             var cts = ActivityCancellationTokenSource.Rent(TimeSpan.FromSeconds(10), CancellationToken.None);
             cts.Return();
@@ -28,6 +28,8 @@ public void ActivityCancellationTokenSource_PoolsSources()
             {
                 return;
             }
+
+            await Task.Delay(1);
         }
 
         Assert.Fail("CancellationTokenSources were not pooled");