Skip to content

Commit

Permalink
fix wrong method overload signature on stoppers
Browse files Browse the repository at this point in the history
  • Loading branch information
douglasrizzo committed Mar 25, 2024
1 parent c55301b commit 66d59af
Showing 1 changed file with 13 additions and 2 deletions.
15 changes: 13 additions & 2 deletions src/catsim/stopping.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
from typing import Any

import numpy

from . import irt
Expand All @@ -23,7 +25,12 @@ def __init__(self, max_itens: int) -> None:
super().__init__()
self._max_itens = max_itens

def stop(self, index: int | None = None, administered_items: numpy.ndarray = None) -> bool:
def stop(
self,
index: int | None = None,
administered_items: numpy.ndarray = None,
**kwargs: dict[str, Any], # noqa: ARG002
) -> bool:
"""Check whether the test reached its stopping criterion for the given user.
:param index: the index of the current examinee
Expand Down Expand Up @@ -73,7 +80,11 @@ def __init__(self, min_error: float) -> None:
self._min_error = min_error

def stop(
self, index: int | None = None, administered_items: numpy.ndarray = None, theta: float | None = None
self,
index: int | None = None,
administered_items: numpy.ndarray = None,
theta: float | None = None,
**kwargs: dict[str, Any], # noqa: ARG002
) -> bool:
"""Check whether the test reached its stopping criterion.
Expand Down

0 comments on commit 66d59af

Please sign in to comment.