Cloning, Model Validation #39
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpguthrie
commented
Sep 27, 2022
| git_provider_webhook: Optional[bool] = None | ||
|
|
||
|
|
||
| class Job(BaseModel): |
There was a problem hiding this comment.
@matt-winkler Here's what I was thinking as far as doing validation for a particular resource. This is pydantic and it provides this validation out of the box when you provide the schema for the resource.
dpguthrie
commented
Sep 27, 2022
| @@ -77,10 +59,28 @@ def _header_property(self): | |||
|
|
|||
| return 'api_key' | |||
|
|
|||
| def _clone_resource(self, resource: str, **kwargs): | |||
There was a problem hiding this comment.
@matt-winkler A private method that we can use for other resources we'd like to clone
dpguthrie
commented
Sep 27, 2022
| def _make_request( | ||
| self, path: str, *, method: str = 'get', **kwargs | ||
| ) -> requests.Response: | ||
| """Make request to API.""" | ||
|
|
||
| # Model is not an argument that the request method accepts, needs to be removed | ||
| model = kwargs.pop('model', None) |
There was a problem hiding this comment.
@matt-winkler This is where we would pull out the model, if it's been passed. And line 83 below will assign the validated model, with the appropriate defaults, back to the json key.
dpguthrie
commented
Sep 27, 2022
| @@ -291,6 +318,7 @@ def create_job(self, account_id: int, payload: Dict) -> Dict: | |||
| f'accounts/{account_id}/jobs/', | |||
| method='post', | |||
| json=payload, | |||
| model=models.Job, | |||
There was a problem hiding this comment.
@matt-winkler This is where the appropriate model would be passed.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.