Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reveal.js to 4.x #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

pganssle
Copy link
Contributor

@pganssle pganssle commented Nov 6, 2020

There are a number of breaking changes, most of which are documented here: https://revealjs.com/upgrading/

This may not work properly with reveal.js dependencies, since this does not try to upgrade these to use the new plugins mechanism.

There are a number of breaking changes, most of which are documented
here: https://revealjs.com/upgrading/

This may not work properly with reveal.js dependencies, since this does
not try to upgrade these to use the new plugins mechanism.
@dploeger dploeger requested a review from mrmanc November 8, 2020 11:05
@mrmanc
Copy link
Collaborator

mrmanc commented Aug 25, 2022

Thanks for this and apologies that I’ve not looked at it yet. I’m interested in getting things updated, but I find that this update breaks the rendering of the fragments slide. I can’t quite work out why, but the final fragment in the page appears when the slide loads, and there seems to be a phantom fragment before the first one in the page. I’m guessing something nuanced has changed over how reveal.js works with the element classes, but I’m not sure how. I expect this is going to cause a breaking change to existing slides as a result.

If we can understand and fix the rendering, I expect this will be a major release for these reasons.

@mrmanc
Copy link
Collaborator

mrmanc commented Aug 26, 2022

As a note, I believe anyone wishing to change to this will need to cd reveal.js && git checkout 4.0.2 in order to update the submodule. There’s probably a simpler way to pull that change as part of pulling the repo, but it caught me out.

@Sieboldianus
Copy link

Sieboldianus commented Dec 6, 2022

Many thanks! Tested this and everything works, except data-background-image elements won't render. I'll add information once I found the reason.

[edit] This was my fault, I used "image/link" instead of without quotes. Everything works.

@Sieboldianus
Copy link

Sieboldianus commented Dec 7, 2022

Thank you! The suggested edits worked flawlessly for me for reveal 4.4.0. I also added a number of hooks to support new functions:

| replace:'<slide-id>','<!-- .slide: id="'
| replace:'</slide-id>','" --> '
| replace:'<slidevisibility>','<!-- .slide: data-visibility="'
| replace:'</slidevisibility>','" --> '
| replace:'<auto-animate/>','<!-- .slide: data-auto-animate -->'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants