Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifying hover background color #156

Merged
merged 1 commit into from
May 26, 2020
Merged

Modifying hover background color #156

merged 1 commit into from
May 26, 2020

Conversation

AnilSonix
Copy link
Contributor

Modifying
editor.hoverHighlightBackground"

Fix for
#152

#154

@AnilSonix
Modifying hover background color
55e8e16 
Modifying
editor.hoverHighlightBackground"

Fix for
dracula#152

dracula#154
@AnilSonix AnilSonix marked this pull request as ready for review May 22, 2020 02:10
@dsifford
Copy link
Member

dsifford commented May 22, 2020 •
edited
Loading

2 things:

  1. I'd like to at least be able to reproduce this problem myself before merging this PR (of which currently I cannot, even after following your instructions in Path gets blacked on hover in terminal if hoverHighlightBackground is opaque microsoft/vscode#97521).
  2. Please upload a screenshot of the changes.

@AnilSonix
Copy link
Contributor Author

@dsifford
I'm having this bug in both Ubuntu and Windows machine.
With extensions disabled, it doesn't happen.
Screenshot from 2020-05-23 09-05-10
Screenshot from 2020-05-23 09-05-31

Is there way to know which extension might be responsible?

@dsifford
Copy link
Member

@AnilSonix So just to be clear, with all extensions disabled, but with dracula enabled, it doesn't happen?

@AnilSonix
Copy link
Contributor Author

@dsifford Yes , all disabled except Dracula theme
Screenshot from 2020-05-23 22-18-30

@dsifford
Copy link
Member

Aha, I finally was able to repro this.

This looks fine to me. I'll release an update shortly. Thanks!

@dsifford dsifford merged commit e895a2a into dracula:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnilSonix @dsifford