Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gc configuration for dfdaemon #142

Merged
merged 1 commit into from
Dec 13, 2023
Merged

feat: add gc configuration for dfdaemon #142

merged 1 commit into from
Dec 13, 2023

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

@gaius-qi gaius-qi added the enhancement New feature or request label Dec 12, 2023
@gaius-qi gaius-qi added this to the v1.0.0 milestone Dec 12, 2023
@gaius-qi gaius-qi self-assigned this Dec 12, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner December 12, 2023 14:06
yxxhero
yxxhero previously approved these changes Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #142 (0554294) into main (32dd257) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##            main    #142      +/-   ##
========================================
- Coverage   1.75%   1.74%   -0.01%     
========================================
  Files         29      29              
  Lines       3476    3491      +15     
========================================
  Hits          61      61              
- Misses      3415    3430      +15     
Files Coverage Δ
src/lib.rs 9.09% <ø> (ø)
src/config/dfdaemon.rs 0.00% <0.00%> (ø)

Copy link

@hyy0322 hyy0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit c11b49a into main Dec 13, 2023
5 checks passed
@gaius-qi gaius-qi deleted the feature/gc branch December 13, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants