Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove redirect stderr to file #938

Merged
merged 1 commit into from
Jan 9, 2025
Merged

feat: remove redirect stderr to file #938

merged 1 commit into from
Jan 9, 2025

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Jan 9, 2025

Description

This pull request includes several changes to the dragonfly-client project, focusing on dependency updates and code cleanup. The most important changes include the removal of the libc dependency, cleanup of unused imports, and the removal of the redirect_stderr_to_file function.

Dependency updates:

Code cleanup:

Related Issue

Motivation and Context

Screenshots (if appropriate)

@gaius-qi gaius-qi added the enhancement New feature or request label Jan 9, 2025
@gaius-qi gaius-qi added this to the v2.3.0 milestone Jan 9, 2025
@gaius-qi gaius-qi self-assigned this Jan 9, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner January 9, 2025 08:17
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.47%. Comparing base (7e9ccae) to head (076403a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #938      +/-   ##
==========================================
+ Coverage   34.42%   34.47%   +0.05%     
==========================================
  Files          60       60              
  Lines        9293     9278      -15     
==========================================
  Hits         3199     3199              
+ Misses       6094     6079      -15     
Files with missing lines Coverage Δ
dragonfly-client/src/tracing/mod.rs 0.00% <ø> (ø)

Copy link
Member

@fcgxz2003 fcgxz2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 9ce4632 into main Jan 9, 2025
6 checks passed
@gaius-qi gaius-qi deleted the feature/log branch January 9, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants