Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add iperf3 for Dockerfile and change is_expired for PersistentCacheTask #975

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

gaius-qi
Copy link
Member

Description

This pull request includes changes to the ci/Dockerfile and the dragonfly-client-storage/src/metadata.rs file. The most important changes are the addition of a new package to the Dockerfile and the simplification of the expiration logic in the PersistentCacheTask implementation.

Dockerfile Update:

  • ci/Dockerfile: Added iperf3 to the list of packages installed during the Docker image build process. This addition ensures that iperf3 is available in the Docker image for network performance testing.

PersistentCacheTask Logic Simplification:

  • dragonfly-client-storage/src/metadata.rs: Simplified the expiration check in the is_expired method of the PersistentCacheTask struct by removing the additional time buffer previously used to force eviction. Now, the task is considered expired strictly based on the ttl value.

Related Issue

Motivation and Context

Screenshots (if appropriate)

@gaius-qi gaius-qi added the enhancement New feature or request label Feb 11, 2025
@gaius-qi gaius-qi added this to the v2.3.0 milestone Feb 11, 2025
@gaius-qi gaius-qi self-assigned this Feb 11, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner February 11, 2025 12:32
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.19%. Comparing base (a33f861) to head (c1fc4e9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dragonfly-client-storage/src/metadata.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #975      +/-   ##
==========================================
+ Coverage   33.18%   33.19%   +0.01%     
==========================================
  Files          59       59              
  Lines        9640     9637       -3     
==========================================
  Hits         3199     3199              
+ Misses       6441     6438       -3     
Files with missing lines Coverage Δ
dragonfly-client-storage/src/metadata.rs 58.53% <0.00%> (+0.70%) ⬆️

@gaius-qi gaius-qi merged commit d56dae3 into main Feb 11, 2025
6 of 8 checks passed
@gaius-qi gaius-qi deleted the feature/gc branch February 11, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants