Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: calculate digest of the persistent cache piece to check the integrity of the metadata #980

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Feb 14, 2025

Description

This pull request includes several changes to improve the calculation and verification of piece metadata digests in the dragonfly-client project. The key changes involve updating the calculate_digest method, ensuring the integrity of piece metadata, and updating dependencies.

Digest Calculation and Verification:

Dependency Updates:

  • Cargo.toml: Updated the dragonfly-api dependency version from 2.1.25 to 2.1.27.

Documentation Updates:

Related Issue

dragonflyoss/dragonfly#3811

Motivation and Context

Screenshots (if appropriate)

@gaius-qi gaius-qi added the enhancement New feature or request label Feb 14, 2025
@gaius-qi gaius-qi added this to the v2.3.0 milestone Feb 14, 2025
@gaius-qi gaius-qi self-assigned this Feb 14, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner February 14, 2025 03:41
@gaius-qi gaius-qi force-pushed the feature/piece-metadata branch from 410e320 to d77f519 Compare February 14, 2025 03:43
@gaius-qi gaius-qi force-pushed the feature/piece-metadata branch from d77f519 to eca925b Compare February 14, 2025 03:47
@gaius-qi gaius-qi force-pushed the feature/piece-metadata branch from eca925b to 2fbce17 Compare February 14, 2025 03:51
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 32 lines in your changes missing coverage. Please review.

Project coverage is 33.07%. Comparing base (32c99b7) to head (2fbce17).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dragonfly-client/src/resource/piece_downloader.rs 0.00% 25 Missing ⚠️
dragonfly-client/src/grpc/dfdaemon_upload.rs 0.00% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #980      +/-   ##
==========================================
- Coverage   33.18%   33.07%   -0.11%     
==========================================
  Files          59       59              
  Lines        9727     9741      +14     
==========================================
- Hits         3228     3222       -6     
- Misses       6499     6519      +20     
Files with missing lines Coverage Δ
dragonfly-client-storage/src/metadata.rs 62.08% <100.00%> (-0.83%) ⬇️
dragonfly-client-util/src/digest/mod.rs 80.48% <ø> (ø)
dragonfly-client/src/grpc/dfdaemon_upload.rs 0.00% <0.00%> (ø)
dragonfly-client/src/resource/piece_downloader.rs 2.66% <0.00%> (-0.67%) ⬇️

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@CormickKneey CormickKneey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit 04c71e6 into main Feb 14, 2025
6 checks passed
@gaius-qi gaius-qi deleted the feature/piece-metadata branch February 14, 2025 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants