Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE Several attempts to run Crowdin CLI #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dshiryaev-plesk
Copy link

Hello,
Thank you for your work!
Crowdin has moved their CLI in version v3 to Crowdin API v2. Crowdin API v2 works unstable, so does Crowdin CLI v3. These changes adds an ability to recall Crowdin CLI several times with an exponential backoff in case Crowdin CLI fails. The default values for the backoff:

- backoff_max_attempts:	3
- backoff_exp_base:		8

Example for .serge config:

sync
{
    ts
    {
        plugin      crowdin
        data
        {
            backoff_max_attempts	3
    		backoff_exp_base		8
        }
    }
}

Can, you consider these changes to merge, please ?

@dragosv
Copy link
Owner

dragosv commented May 13, 2022

@dshiryaev-plesk I would prefer to rename backoff to retry (so backoff_max_attempts will be retry_max_attempts). As well there are no new tests for the new functionality, while the existing ones are failing. Plus I would like the defaults for the new values to be retry_max_attempts to be 1. As well a better name should be used for backoff_exp_base (It is not clear what it represents)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants