Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make send() more robust by handling previous ACK #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davispuh
Copy link

@davispuh davispuh commented Dec 3, 2024

Syslinux TFTP sometimes sends previous ACK sequence.
This PR allows such behavior making it work :)

Without this PR it would fail like this

ℹ info    [192.168.0.135:49153] New initial packet received
• debug   [192.168.0.135:49153] -> PKT: #<struct TFTP::Packet::RRQ filename="initrd", mode=:octet>
⚠ warning [192.168.0.135:49153:5389 ] Seq mismatch: 53467 != 53466
ℹ info    [192.168.0.135:49153:5389 ] Session ended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant