New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sanitizing agent name before pushing to docker registry (ENG-672) #27

Merged

evilsocket merged 1 commit into main from simone/eng-672-cli-strikes-always-lowercase-the-agent-name

Dec 18, 2024

Contributor

evilsocket commented Dec 18, 2024

No description provided.


          fix: sanitizing agent name before pushing to docker registry (ENG-672)

b3fc711

linear bot commented Dec 18, 2024

ENG-672 CLI / Strikes: always lowercase the agent name

As per https://docs.google.com/document/d/17aHyIYkQvNZGKPPFUGPzu6KtrlD4WpMdu-9-vLyWqVo/edit?tab=t.0 :

Can you just str.lowercase() for the user? Or throw an error earlier in some sort of linting step? This was on the push.
- `http+docker://localhost/v1.47/images/sha256:eeeb15501b1b24b0d6dd4b9f5e6c7594ee4d5d6dd165ec644f3e85beeb76e71c/tag?tag=eb76e71c&repo=registry.dreadnode.io%2Fjoe%2Fagents%2FMorpheus_Falco&force=0: Bad Request ("invalid reference format: repository name (joe/agents/Morpheus_Falco) must be lowercase")`
- This is in the strikes beta docs: https://dreadnode.notion.site/strikes-beta-program#1571ad120376802aa7f1e9c73f7db6f7
  - But that name triggers the same problem
  - http+docker://localhost/v1.47/images/sha256:f98eee2e0fd74570d65813b5ea1a16b8d6459158809e9e12793e505499577db0/tag?tag=99577db0&repo=r
  - egistry.dreadnode.io%2Fjoe%2Fagents%2FMy_First_Falco&force=0: Bad Request ("invalid reference format: repository name
  - (joe/agents/My_First_Falco) must be lowercase")

evilsocket merged commit 348d0c6 into main

1 check passed

evilsocket deleted the simone/eng-672-cli-strikes-always-lowercase-the-agent-name branch

January 7, 2025 13:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet