Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: b64 encoded identifiers #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

briangreunke
Copy link

@briangreunke briangreunke commented Feb 1, 2025

Base64 Encoded Generator Identifiers

  • if a generator identifier string ends in = the split function (on =) splits into too large of a list
  • instead, just split on the first = as the rest of the string is comma delimited

Generated Summary

  • Updated call signatures in the LazyGenerator and Generator classes for improved clarity and consistency.
  • Modified the get_generator function to ensure it splits on the first equal sign to avoid potential issues with arguments containing = in their values.
  • Added a new test test_get_generator_b64 that verifies the functionality of get_generator with a base64 encoded API key, ensuring robust handling of inputs.
  • Removed placeholder ellipses to finalize method signatures in the Generator class methods, enhancing code readability.

This summary was generated with ❤️ by rigging

- if a generator identifier string ends in , the split function (on ) splits into too large of an array
- instead, just split on the first  as the rest of the string is comma delimtited
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant