Describe service #209
Open
Describe service #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if labelsJSON != "" { | ||
| err := json.Unmarshal([]byte(labelsJSON), &labels) | ||
| if err != nil { | ||
| log.Fatal("Error parsing JSON, the the key and values should be strings: ", err) |
There was a problem hiding this comment.
If the input is not a valid json, then will this error message will be misleading?
|
|
||
| var serviceName string | ||
| var serviceVersion string | ||
| var labelsJSON string |
There was a problem hiding this comment.
Should we use camel case consistently?
| optional google.protobuf.Struct labels = 7; | ||
| optional google.protobuf.Struct service_definition = 8; | ||
| repeated google.protobuf.Struct provisioning_config_files = 9; | ||
| repeated string versions = 10; |
There was a problem hiding this comment.
Why do we have both version and versions?
| } | ||
|
|
||
| message DescribeServiceRequest { | ||
| string service_name = 1; |
There was a problem hiding this comment.
Should we be consistent in naming these eg. either have name and version OR service_name and service_version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Odin version(x.y.z)
Features
Resources