Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1214] Added script to find and load SSH keys. #1216

Merged

Conversation

AlexSkrypnyk
Copy link
Member

@AlexSkrypnyk AlexSkrypnyk commented Mar 3, 2024

Closes #1214

Changed:

  • Unified DREVOPS_<PREFIX>_SSH_FILE variable name accross scripts.
  • Renamed DREVOPS_DB_DOWNLOAD_SSH_KEY_FILE to DREVOPS_DB_DOWNLOAD_SSH_FILE.
  • Updated drevops/ci-runner to 24.3.0.

@AlexSkrypnyk AlexSkrypnyk added this to the 1.20 milestone Mar 3, 2024
@AlexSkrypnyk AlexSkrypnyk force-pushed the feature/1214-add-sha256-keys-support-circleci branch 3 times, most recently from 46ea26f to 281411d Compare March 4, 2024 01:33
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 54.83871% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 72.50%. Comparing base (9332b71) to head (c9a58bd).
Report is 1 commits behind head on develop.

Files Patch % Lines
scripts/drevops/setup-ssh.sh 59.18% 20 Missing ⚠️
scripts/drevops/download-db-lagoon.sh 0.00% 4 Missing ⚠️
scripts/drevops/mirror-code.sh 0.00% 2 Missing ⚠️
scripts/drevops/doctor.sh 50.00% 1 Missing ⚠️
scripts/drevops/task-custom-lagoon.sh 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1216      +/-   ##
===========================================
+ Coverage    71.93%   72.50%   +0.57%     
===========================================
  Files           38       39       +1     
  Lines         2843     2855      +12     
===========================================
+ Hits          2045     2070      +25     
+ Misses         798      785      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexSkrypnyk AlexSkrypnyk force-pushed the feature/1214-add-sha256-keys-support-circleci branch from 2f554c4 to 6ad6c16 Compare March 4, 2024 04:19
Also, unified `DREVOPS_<PREFIX>_SSH_FILE` variable name accross scripts.

Renamed `DREVOPS_DB_DOWNLOAD_SSH_KEY_FILE` to `DREVOPS_DB_DOWNLOAD_SSH_FILE`.

Updated `drevops/ci-runner` to `24.3.0`.
@AlexSkrypnyk AlexSkrypnyk force-pushed the feature/1214-add-sha256-keys-support-circleci branch from 6ad6c16 to c9a58bd Compare March 4, 2024 04:21
@AlexSkrypnyk AlexSkrypnyk marked this pull request as ready for review March 4, 2024 04:22
@AlexSkrypnyk AlexSkrypnyk merged commit f8c5e08 into develop Mar 4, 2024
18 of 19 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/1214-add-sha256-keys-support-circleci branch March 4, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add support for SHA256 fingerprint into all scripts
1 participant