Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ #1213] Updated tests for notify scripts to use the step runner format. #1221

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

richardgaunt
Copy link
Collaborator

@richardgaunt richardgaunt commented Mar 8, 2024

Partial implementation of #1213

Checklist before requesting a review

  • I have formatted the subject to include ticket number as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

  1. Updated most tests to step_runner - note multi-line strings don't work with this helper.

Screenshots

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.50%. Comparing base (55674fd) to head (d1067d6).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1221   +/-   ##
========================================
  Coverage    72.50%   72.50%           
========================================
  Files           39       39           
  Lines         2855     2855           
========================================
  Hits          2070     2070           
  Misses         785      785           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AlexSkrypnyk AlexSkrypnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardgaunt
Could you please revert the changes to tests that are not using mocks. We need to use STEPS only with tests that user the mocking system.

Sorry, I should have been more clear about the requirements.

@@ -8,48 +8,75 @@ load _helper.bash

@test "Notify: skip" {
pushd "${LOCAL_REPO_DIR}" >/dev/null || exit 1
declare -a STEPS=(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardgaunt
Could you please revert this. I should have been more clear: we need to only convert tests that are using mocks. This one does not use mocks so it is easier to maintain it as normal asserts. sorry

@AlexSkrypnyk AlexSkrypnyk changed the title #1213 Updated to step runner format. #1213 Updated testsmto step runner format. Mar 8, 2024
@AlexSkrypnyk AlexSkrypnyk changed the title #1213 Updated testsmto step runner format. [ #1213] Updated tests for notify scripts to use the step runner format. Mar 14, 2024
@AlexSkrypnyk AlexSkrypnyk enabled auto-merge (squash) March 14, 2024 19:53
@AlexSkrypnyk AlexSkrypnyk disabled auto-merge March 14, 2024 19:53
@AlexSkrypnyk AlexSkrypnyk merged commit ad5531c into develop Mar 14, 2024
18 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the update-to-steps branch March 14, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants