-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ #1213] Updated tests for notify scripts to use the step runner format. #1221
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1221 +/- ##
========================================
Coverage 72.50% 72.50%
========================================
Files 39 39
Lines 2855 2855
========================================
Hits 2070 2070
Misses 785 785 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richardgaunt
Could you please revert the changes to tests that are not using mocks. We need to use STEPS
only with tests that user the mocking system.
Sorry, I should have been more clear about the requirements.
.drevops/tests/bats/notify.bats
Outdated
@@ -8,48 +8,75 @@ load _helper.bash | |||
|
|||
@test "Notify: skip" { | |||
pushd "${LOCAL_REPO_DIR}" >/dev/null || exit 1 | |||
declare -a STEPS=( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richardgaunt
Could you please revert this. I should have been more clear: we need to only convert tests that are using mocks. This one does not use mocks so it is easier to maintain it as normal asserts. sorry
Partial implementation of #1213
Checklist before requesting a review
[#123] Verb in past tense with dot at the end.
Changed
section about WHY something was done if this was not a normal implementationChanged
Screenshots