Skip to content

Commit

Permalink
[Cases] Fix columns popover flaky tests (elastic#175509)
Browse files Browse the repository at this point in the history
## Summary

Fixes elastic#174684
Fixes elastic#174683
Fixes elastic#174682

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
  • Loading branch information
js-jankisalvi authored Jan 25, 2024
1 parent 02a53bd commit e2d8fa7
Showing 1 changed file with 15 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,7 @@ import type { AppMockRenderer } from '../../common/mock';
import { createAppMockRenderer } from '../../common/mock';
import { ColumnsPopover } from './columns_popover';

// FLAKY: https://github.com/elastic/kibana/issues/174682
// FLAKY: https://github.com/elastic/kibana/issues/174683
// FLAKY: https://github.com/elastic/kibana/issues/174684
describe.skip('ColumnsPopover', () => {
describe('ColumnsPopover', () => {
let appMockRenderer: AppMockRenderer;

beforeEach(() => {
Expand Down Expand Up @@ -85,7 +82,13 @@ describe.skip('ColumnsPopover', () => {
);

userEvent.click(await screen.findByTestId('column-selection-popover-button'));
userEvent.click(await screen.findByTestId('column-selection-popover-show-all-button'));
userEvent.click(
await screen.findByTestId('column-selection-popover-show-all-button'),
undefined,
{
skipPointerEventsCheck: true,
}
);

const onSelectedColumnsChangeCallParams = selectedColumns.map((column) => ({
...column,
Expand All @@ -108,7 +111,13 @@ describe.skip('ColumnsPopover', () => {
);

userEvent.click(await screen.findByTestId('column-selection-popover-button'));
userEvent.click(await screen.findByTestId('column-selection-popover-hide-all-button'));
userEvent.click(
await screen.findByTestId('column-selection-popover-hide-all-button'),
undefined,
{
skipPointerEventsCheck: true,
}
);

await waitFor(() => {
expect(onSelectedColumnsChange).toHaveBeenCalledWith(
Expand Down

0 comments on commit e2d8fa7

Please sign in to comment.