Merge pull request #1046 from jiajic/suite_dev

fix warning
drieslab · Oct 8, 2024 · 221d5ec · 221d5ec
2 parents d481d44 + c0782f4
commit 221d5ec
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/R/dimension_reduction.R b/R/dimension_reduction.R
@@ -1821,10 +1821,12 @@ jackstrawPlot <- function(gobject,
              "\nnumber of estimated significant components: ",
              nr_sign_components)
 
-        warning(wrap_txt(
-            "Number of significant components equals `ncp`.
+        if (ncp <= nr_sign_components) {
+            warning(wrap_txt(
+                "Number of significant components equals `ncp`.
             Increasing `ncp` may be needed."
-        ))
+            ))
+        }
 
         final_results <- jtest[c("p", "cum_var_explained")]
         vmsg(.v = verbose, .is_debug = TRUE, final_results$p)