Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.0.0.9005 #19

Merged
merged 7 commits into from
Oct 23, 2023
Merged

v0.0.0.9005 #19

merged 7 commits into from
Oct 23, 2023

Conversation

jiajic
Copy link
Member

@jiajic jiajic commented Oct 23, 2023

  • fix: issue where the same node referred to by target and source cols will be incorrectly assumed to be two different nodes
  • add: default nodePadding = 1 and sinksRight = FALSE
  • fix: iterative node indexing which did not increment properly
  • fix: data.frame method now enforces conversion to data.table
  • add: method for lists of data.frames that will allow sankey generation stepwise so that identical node names can be considered independent if they originate from different data.frames in the list. Contrast with simply using rbind() which puts two sets of data.frames together into the same sankey generation.

- fix issue where the same node referred to by target and source cols will be incorrectly assumed to be two different nodes
- add default nodePadding of 1 and sinksRight = FALSE
- fix: iterative node indexing
- fix: data.frame method now enforces conversion to `data.table`
- add: method for lists of `data.frames` that will allow sankey generation stepwise so that identical node values can be considered independent if they originate from different data.tables in the list.

contrast with simply using `rbind()` which puts two sets of data.tables together into the same sankey generation.
update: `sankeyPlot()`
version bump
@jiajic jiajic merged commit db6ac69 into main Oct 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant