-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker setup #1428
Draft
efstajas
wants to merge
39
commits into
main
Choose a base branch
from
jason/docker-setup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Docker setup #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚅 Deployed to the app-pr-1428 environment in Drips App
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for improved Docker setup.
Changes:
Dockerfile
that can be used to deploy a production build on Railway, build a generic production image, and building an image for development that can run the dev serverdocker-compose.yml
file that (for now) spins up a Redis and dev container of the appgetOptionalEnvVar
utils now allow specifying whether the variable is required in productiongetOptionalEnvVar
will now warn about a variable that is required in prod but not def missing, including clear logs about what functionality will be missing / not work properly given the lack of any particular variablenpm run gql:generate-schema
command will only fetch schema from remote GQL server usingGQL_URL
andGQL_ACCESS_TOKEN
, and create a (gitignored)schema.graphql
file in root dirnpm run gql:build-types
command will build GQL types based onschema.graphql
file.npm run gql:build
command combines the two above commands into one.schema.graphql
file being present in root dir. This allows building a production image including GQL types without leakingGQL_ACCESS_TOKEN
into the built image.GQL_URL
andGQL_ACCESS_TOKEN
directly into the image build is possible so that Railway can build properly.Todo:
docker-compose
for development.env.template
DEVELOPMENT.md
documentation