fix(az): catch HttpResponseError in _check_hns #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #487 +/- ##
========================================
- Coverage 94.4% 93.2% -1.3%
========================================
Files 23 23
Lines 1776 1776
========================================
- Hits 1678 1656 -22
- Misses 98 120 +22
|
pjbull
requested changes
Nov 22, 2024
cloudpathlib/azure/azblobclient.py
Outdated
| @@ -202,7 +202,7 @@ def _check_hns(self, cloud_path: AzureBlobPath) -> Optional[bool]: | |||
| try: | |||
| account_info = self.service_client.get_account_information() # type: ignore | |||
| self._hns_enabled = account_info.get("is_hns_enabled", False) # type: ignore | |||
| except ResourceNotFoundError: | |||
| except (ResourceNotFoundError, HttpResponseError): | |||
There was a problem hiding this comment.
Per the stack trace in #486, can we confirm the error code is ErrorCode:AuthorizationPermissionMismatch and if not, re-raise the HttpResponseError? That will make other potential errors easier to track down.
There was a problem hiding this comment.
Is checking for HTTPStatus.FORBIDDEN sufficient?
M0dEx
force-pushed
the
azure-permission-mismatch
branch
from
01e4eea to
a957e16
Compare
Merged
pjbull
added a commit
that referenced
this pull request
Jan 29, 2025
* fix(az): catch HttpResponseError in _check_hns (#487) * fix(az): catch HttpResponseError in _check_hns * chore: update HISTORY.md * format * cast fallback * review comment --------- Co-authored-by: Jakub Kubík <[email protected]>
fafnirZ
pushed a commit
to fafnirZ/cloudpathlib
that referenced
this pull request
Feb 11, 2025
* fix(az): catch HttpResponseError in _check_hns (drivendataorg#487) * fix(az): catch HttpResponseError in _check_hns * chore: update HISTORY.md * format * cast fallback * review comment --------- Co-authored-by: Jakub Kubík <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an uncaught exception in
check_hns, which can fail with theHttpResponseErrorwhen supplied with aDefaultAzureCredential.Closes #486.