Make copy of list class attrs

dropseed · Jan 10, 2024 · 1593d4a · 1593d4a
1 parent 1329f55
commit 1593d4a
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/bolt-admin/bolt/admin/views/base.py b/bolt-admin/bolt/admin/views/base.py
@@ -168,13 +168,15 @@ def get_objects(self) -> list:
         return []
 
     def get_fields(self) -> list:
-        return self.fields
+        return (
+            self.fields.copy()
+        )  # Avoid mutating the class attribute if using append etc
 
     def get_actions(self) -> dict[str]:
-        return self.actions
+        return self.actions.copy()  # Avoid mutating the class attribute itself
 
     def get_filters(self) -> list[str]:
-        return self.filters
+        return self.filters.copy()  # Avoid mutating the class attribute itself
 
     def get_object_field(self, obj, field: str):
         # Try basic dict lookup first