[10.x] Re-formatted CI and added more PHP versions to the test matrix. #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexSkrypnyk
force-pushed
the
feature/10x-cleanup-gha
branch
from
49fb57c to
db4ee50
Compare
AlexSkrypnyk
changed the title
AlexSkrypnyk
commented
May 14, 2024
| run: ./vendor/bin/phpunit -c ./web/core ./web/core/modules/user/tests/src/Unit/UserAccessControlHandlerTest.php | ||
|
|
||
| - run: ./vendor/bin/drush |
There was a problem hiding this comment.
this is not needed - Drush was used above to install the site and run the server
AlexSkrypnyk
commented
May 14, 2024
|
|
||
| # https://www.drupal.org/project/drupal/issues/3182653 | ||
| # https://www.drupal.org/node/3176567 | ||
| - if: ${{ matrix.php-versions == '8.1' }} |
There was a problem hiding this comment.
moved above to the part where all of the code base is prepared
AlexSkrypnyk
commented
May 14, 2024
|
|
||
| - run: ./vendor/bin/drush site-install --verbose --yes --db-url=sqlite://tmp/site.sqlite | ||
| - name: Override Drupal version to dev for testing dev releases |
There was a problem hiding this comment.
this is a single operation, so combined multiple steps
AlexSkrypnyk
commented
May 14, 2024
| php-versions: ['8.1'] | ||
| drupal-release: ['stable'] | ||
| composer-channel: ['stable'] | ||
| php-versions: ['8.1', '8.2'] |
There was a problem hiding this comment.
| PHP Versions | Drupal Release | Composer Channel |
|---|---|---|
| 8.1 | stable | stable |
| 8.1 | stable | snapshot |
| 8.1 | dev | stable |
| 8.1 | dev | snapshot |
| 8.2 | stable | stable |
| 8.2 | stable | snapshot |
| 8.2 | dev | stable |
| 8.2 | dev | snapshot |
| 8.3 | stable | stable |
| 8.3 | stable | snapshot |
|
@leymannx |
normanlolx
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the CI config to have names for each job for consistency.
I've also added additional PHP versions to test:
Note that Drupal 10.x-dev tests fail on PHP 8.3. https://www.drupal.org/project/drupal/issues/3375693