Add Drupal Dependencies commands to Drush core #6060
Conversation
claudiu-cristea
requested review from
weitzman and
greg-1-anderson
as code owners
claudiu-cristea
force-pushed
the
drupal-dependencies
branch
3 times, most recently
from
aed0bf2 to
63b4944
Compare
|
Blocked on #6061 |
|
Unblocking. Resolving w/o #6061 for now |
claudiu-cristea
force-pushed
the
drupal-dependencies
branch
from
8956987 to
2c0ecdf
Compare
claudiu-cristea
force-pushed
the
drupal-dependencies
branch
2 times, most recently
from
b8bda10 to
8956987
Compare
claudiu-cristea
force-pushed
the
drupal-dependencies
branch
from
9dff50c to
3080418
Compare
|
Ok, let's see what Drush maintainers have to say. In the future we can expand with more |
docs/drupal-dependencies.md
Outdated
|
|
||
| Drupal modules are able to define other modules as dependencies, using the module's [metadata info.yml file](https://www.drupal.org/docs/develop/creating-modules/let-drupal-know-about-your-module-with-an-infoyml-file). To get all modules that depend on a given module type: | ||
|
|
||
| drush why:module node --dependent-type=module |
There was a problem hiding this comment.
How about just --type? Its briefer, and easier to spell.
| private array $dependents = []; | ||
| private array $tree = []; | ||
| private array $relation = []; | ||
| private array $dependencies = [ | ||
| 'module-module' => [], | ||
| 'config-module' => [], | ||
| 'config-config' => [], | ||
| ]; |
There was a problem hiding this comment.
PHPDoc for these would be helpful IMO
| /** | ||
| * @param string $dependency | ||
| * @param array $path | ||
| */ |
There was a problem hiding this comment.
Lets do a 1 line summary of the method, and omit phpdoc on params if they add nothing above whats in the function signature. Same for methods below.
| { | ||
| $entityTypeManager = \Drupal::entityTypeManager(); | ||
| $configTypeIds = array_keys( | ||
| array_filter($entityTypeManager->getDefinitions(), function (EntityTypeInterface $entityType): bool { |
There was a problem hiding this comment.
could you improve readability with an arrow function here? https://medium.com/@albertcolom/how-to-use-arrow-function-in-php-c28490ff7fb7
| { | ||
| return new self( | ||
| $container->get('extension.list.module'), | ||
| $container->getParameter('container.modules') |
There was a problem hiding this comment.
This container param I wanted to autowire, so I've opened #6061
|
Ready for a 2nd round of review |
|
This looks great to me. I will merge in a day or two unless we get more discussion here. |
Add https://github.com/claudiu-cristea/drupal-dependencies to Drupal core