Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing last named import/export should not remove or change declaration #1599

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

dsherret
Copy link
Owner

This should be left to the user to decide what should happen.

Closes #1551

@dsherret dsherret merged commit 3d41ded into latest Dec 30, 2024
2 checks passed
@dsherret dsherret deleted the fix_do_not_remove_named_exports_imports branch December 30, 2024 16:52
renovate bot added a commit to mmkal/expect-type that referenced this pull request Jan 26, 2025
##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0)

#### What's Changed

-   feat: TypeScript 5.7.2 dsherret/ts-morph#1594
-   fix: switch back to fast-glob for stability dsherret/ts-morph#1595
-   fix: properly insert async keyword in arrow function dsherret/ts-morph#1597
-   fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598
-   fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599

**Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0
##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0)

#### What's Changed

-   perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549
-   perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558
-   fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557
-   fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560
-   feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576

#### New Contributors

-   [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549
-   [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557

**Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
renovate bot added a commit to mmkal/expect-type that referenced this pull request Jan 28, 2025
##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0)

#### What's Changed

-   feat: TypeScript 5.7.2 dsherret/ts-morph#1594
-   fix: switch back to fast-glob for stability dsherret/ts-morph#1595
-   fix: properly insert async keyword in arrow function dsherret/ts-morph#1597
-   fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598
-   fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599

**Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0
##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0)

#### What's Changed

-   perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549
-   perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558
-   fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557
-   fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560
-   feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576

#### New Contributors

-   [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549
-   [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557

**Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
renovate bot added a commit to mmkal/expect-type that referenced this pull request Feb 1, 2025
##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0)

#### What's Changed

-   feat: TypeScript 5.7.2 dsherret/ts-morph#1594
-   fix: switch back to fast-glob for stability dsherret/ts-morph#1595
-   fix: properly insert async keyword in arrow function dsherret/ts-morph#1597
-   fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598
-   fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599

**Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0
##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0)

#### What's Changed

-   perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549
-   perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558
-   fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557
-   fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560
-   feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576

#### New Contributors

-   [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549
-   [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557

**Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
renovate bot added a commit to mmkal/expect-type that referenced this pull request Feb 2, 2025
##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0)

#### What's Changed

-   feat: TypeScript 5.7.2 dsherret/ts-morph#1594
-   fix: switch back to fast-glob for stability dsherret/ts-morph#1595
-   fix: properly insert async keyword in arrow function dsherret/ts-morph#1597
-   fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598
-   fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599

**Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0
##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0)

#### What's Changed

-   perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549
-   perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558
-   fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557
-   fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560
-   feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576

#### New Contributors

-   [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549
-   [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557

**Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
renovate bot added a commit to mmkal/expect-type that referenced this pull request Feb 5, 2025
##### [v25.0.1](https://github.com/dsherret/ts-morph/releases/tag/25.0.1)

##### Bug Fixes

-   bump TypeScript from 5.7.2 to 5.7.3 ([#1608](dsherret/ts-morph#1608)) ([a7397a0](dsherret/ts-morph@a7397a0))
-   update browser field to include fs/promises ([#1606](dsherret/ts-morph#1606)) ([ef81097](dsherret/ts-morph@ef81097))
##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0)

#### What's Changed

-   feat: TypeScript 5.7.2 dsherret/ts-morph#1594
-   fix: switch back to fast-glob for stability dsherret/ts-morph#1595
-   fix: properly insert async keyword in arrow function dsherret/ts-morph#1597
-   fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598
-   fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599

**Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0
##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0)

#### What's Changed

-   perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549
-   perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558
-   fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557
-   fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560
-   feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576

#### New Contributors

-   [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549
-   [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557

**Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
renovate bot added a commit to mmkal/expect-type that referenced this pull request Feb 12, 2025
##### [v25.0.1](https://github.com/dsherret/ts-morph/releases/tag/25.0.1)

##### Bug Fixes

-   bump TypeScript from 5.7.2 to 5.7.3 ([#1608](dsherret/ts-morph#1608)) ([a7397a0](dsherret/ts-morph@a7397a0))
-   update browser field to include fs/promises ([#1606](dsherret/ts-morph#1606)) ([ef81097](dsherret/ts-morph@ef81097))
##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0)

#### What's Changed

-   feat: TypeScript 5.7.2 dsherret/ts-morph#1594
-   fix: switch back to fast-glob for stability dsherret/ts-morph#1595
-   fix: properly insert async keyword in arrow function dsherret/ts-morph#1597
-   fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598
-   fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599

**Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0
##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0)

#### What's Changed

-   perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549
-   perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558
-   fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557
-   fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560
-   feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576

#### New Contributors

-   [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549
-   [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557

**Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
renovate bot added a commit to mmkal/expect-type that referenced this pull request Feb 12, 2025
##### [v25.0.1](https://github.com/dsherret/ts-morph/releases/tag/25.0.1)

##### Bug Fixes

-   bump TypeScript from 5.7.2 to 5.7.3 ([#1608](dsherret/ts-morph#1608)) ([a7397a0](dsherret/ts-morph@a7397a0))
-   update browser field to include fs/promises ([#1606](dsherret/ts-morph#1606)) ([ef81097](dsherret/ts-morph@ef81097))
##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0)

#### What's Changed

-   feat: TypeScript 5.7.2 dsherret/ts-morph#1594
-   fix: switch back to fast-glob for stability dsherret/ts-morph#1595
-   fix: properly insert async keyword in arrow function dsherret/ts-morph#1597
-   fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598
-   fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599

**Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0
##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0)

#### What's Changed

-   perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549
-   perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558
-   fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557
-   fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560
-   feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576

#### New Contributors

-   [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549
-   [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557

**Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
renovate bot added a commit to mmkal/expect-type that referenced this pull request Feb 12, 2025
##### [v25.0.1](https://github.com/dsherret/ts-morph/releases/tag/25.0.1)

##### Bug Fixes

-   bump TypeScript from 5.7.2 to 5.7.3 ([#1608](dsherret/ts-morph#1608)) ([a7397a0](dsherret/ts-morph@a7397a0))
-   update browser field to include fs/promises ([#1606](dsherret/ts-morph#1606)) ([ef81097](dsherret/ts-morph@ef81097))
##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0)

#### What's Changed

-   feat: TypeScript 5.7.2 dsherret/ts-morph#1594
-   fix: switch back to fast-glob for stability dsherret/ts-morph#1595
-   fix: properly insert async keyword in arrow function dsherret/ts-morph#1597
-   fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598
-   fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599

**Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0
##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0)

#### What's Changed

-   perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549
-   perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558
-   fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557
-   fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560
-   feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576

#### New Contributors

-   [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549
-   [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557

**Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing the last named export creates a star export
1 participant