-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature internal 46 logging #400
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nter/METcalcpy into feature_internal_46_logging
@bikegeek and @ishita9 Just wanted to ensure we were waiting for @lisagoodrich to finish up the documentation before approving this request. There is a problem with the documentation - I know what it is I just haven't gotten to it yet (just fyi). |
Oh yes! Lisa needs to finish her part.
Thanks
-Ishita
…On Tue, Oct 1, 2024 at 4:22 PM Julie Prestopnik ***@***.***> wrote:
@bikegeek <https://github.com/bikegeek> and @ishita9
<https://github.com/ishita9> Just wanted to ensure we were waiting for
@lisagoodrich <https://github.com/lisagoodrich> to finish up the
documentation before approving this request. There is a problem with the
documentation - I know what it is I just haven't gotten to it yet (just
fyi).
—
Reply to this email directly, view it on GitHub
<#400 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIYROXGXPVKMDMK27TVGDA3ZZMVCNAVCNFSM6AAAAABPGR5YXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBXGI2TCOBYGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
bikegeek
approved these changes
Oct 2, 2024
Help!!! @bikegeek I'm not finished yet. I have 2 more pages of documentation to add on feature_46_internal_46_logging branch. Is that okay? |
That is OK, I haven't closed the issue yet. Let me know when everything is
ready to go. Thanks for working on the documentation.
…On Wed, Oct 2, 2024 at 12:58 PM lisagoodrich ***@***.***> wrote:
Help!!! @bikegeek <https://github.com/bikegeek> I'm not finished yet. I
have 2 more pages of documentation to add on feature_46_internal_46_logging
branch. Is that okay?
—
Reply to this email directly, view it on GitHub
<#400 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4UJHWKJ3DDOZPU3BSOI7TZZQ65FAVCNFSM6AAAAABPGR5YXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBZGQ3TANBRGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Unit tests to ensure that nothing breaks, SonarQube scan for code reliability and duplication, physically running agg_stat.py and other modules on seneca
Make sure the unit tests pass. Randomly run a few routines like agg_stat to look at the log statements. The log related entries can be made to the sample yaml files. Examples can be found under test directory.
Yes
Yes
If yes, describe the new output and/or changes to the existing output:
Yes, log output will be generated under test_dir/logs
If yes, please describe:
No.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METcalcpy-X.Y.Z Development project for official releases