Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature internal 46 logging #400

Merged
merged 45 commits into from
Oct 2, 2024
Merged

Feature internal 46 logging #400

merged 45 commits into from
Oct 2, 2024

Conversation

ishita9
Copy link
Contributor

@ishita9 ishita9 commented Oct 1, 2024

Pull Request Testing

  • Describe testing already performed for these changes:

    Unit tests to ensure that nothing breaks, SonarQube scan for code reliability and duplication, physically running agg_stat.py and other modules on seneca
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Make sure the unit tests pass. Randomly run a few routines like agg_stat to look at the log statements. The log related entries can be made to the sample yaml files. Examples can be found under test directory.
  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
    Yes
  • Do these changes include sufficient testing updates? [Yes or No]
    Yes
  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

    Yes, log output will be generated under test_dir/logs
  • Do these changes introduce new SonarQube findings? [Yes or No]

    If yes, please describe:
    No.
  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METcalcpy-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@ishita9 ishita9 requested a review from bikegeek October 1, 2024 23:13
@jprestop
Copy link
Collaborator

jprestop commented Oct 1, 2024

@bikegeek and @ishita9 Just wanted to ensure we were waiting for @lisagoodrich to finish up the documentation before approving this request. There is a problem with the documentation - I know what it is I just haven't gotten to it yet (just fyi).

@ishita9
Copy link
Contributor Author

ishita9 commented Oct 1, 2024 via email

@bikegeek bikegeek merged commit 7ae108f into develop Oct 2, 2024
7 checks passed
@lisagoodrich
Copy link
Contributor

Help!!! @bikegeek I'm not finished yet. I have 2 more pages of documentation to add on feature_46_internal_46_logging branch. Is that okay?

@bikegeek
Copy link
Collaborator

bikegeek commented Oct 2, 2024 via email

@jprestop jprestop added this to the METcalcpy-3.0.0 milestone Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

4 participants